Re: [PATCH net-next] usbnet: use netif_tx_wake_queue instead of netif_start_queue

2 messages, 2 authors, 2012-03-17 · open the first message on its own page

Re: [PATCH net-next] usbnet: use netif_tx_wake_queue instead of netif_start_queue

From: Oliver Neukum <hidden>
Date: 2012-03-15 17:05:09

Am Mittwoch, 14. März 2012, 15:00:24 schrieb Alexey Orishko:
If host is going to autosuspend function with two interfaces and
if IP packet has arrived in-between of two usbnet_suspend() callbacks,
i.e usbnet_resume() is called in-between, tx data flow is stopped.
When autosuspend timer expires and device is put to autosuspend
again, tx queue is waked up and data can be sent again.
This behavior might be repeated several times in a row.

Tested on Intel/ARM.

Reviewed-by: Sjur Brændeland <sjur.brandeland-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Tested-by: Dmitry Tarnyagin <dmitry.tarnyagin-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Signed-off-by: Alexey Orishko <alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Acked-by: Oliver Neukum <redacted>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next] usbnet: use netif_tx_wake_queue instead of netif_start_queue

From: David Miller <davem@davemloft.net>
Date: 2012-03-17 05:51:04

From: Oliver Neukum <redacted>
Date: Thu, 15 Mar 2012 18:05:09 +0100
Am Mittwoch, 14. März 2012, 15:00:24 schrieb Alexey Orishko:
quoted
If host is going to autosuspend function with two interfaces and
if IP packet has arrived in-between of two usbnet_suspend() callbacks,
i.e usbnet_resume() is called in-between, tx data flow is stopped.
When autosuspend timer expires and device is put to autosuspend
again, tx queue is waked up and data can be sent again.
This behavior might be repeated several times in a row.

Tested on Intel/ARM.

Reviewed-by: Sjur Brændeland <redacted>
Tested-by: Dmitry Tarnyagin <redacted>
Signed-off-by: Alexey Orishko <redacted>
Acked-by: Oliver Neukum <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help