[PATCH] be2net: Remove unused OFFSET_IN_PAGE() macro

Subsystems: emulex 10gbps nic be2, be3-r, lancer, skyhawk-r driver (be2net), networking drivers, the rest

STALE5287d

3 messages, 2 authors, 2012-03-05 · open the first message on its own page

[PATCH] be2net: Remove unused OFFSET_IN_PAGE() macro

From: Roland Dreier <roland@kernel.org>
Date: 2012-03-01 06:40:53

From: Roland Dreier <redacted>

Signed-off-by: Roland Dreier <redacted>
---
 drivers/net/ethernet/emulex/benet/be.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index cbdec25..cca5c0e 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -428,10 +428,6 @@ extern const struct ethtool_ops be_ethtool_ops;
 		((u32)((((size_t)(_address) & (PAGE_SIZE_4K - 1)) + 	\
 			(size) + (PAGE_SIZE_4K - 1)) >> PAGE_SHIFT_4K))
 
-/* Byte offset into the page corresponding to given address */
-#define OFFSET_IN_PAGE(addr)						\
-		 ((size_t)(addr) & (PAGE_SIZE_4K-1))
-
 /* Returns bit offset within a DWORD of a bitfield */
 #define AMAP_BIT_OFFSET(_struct, field)  				\
 		(((size_t)&(((_struct *)0)->field))%32)
-- 
1.7.9

Re: [PATCH] be2net: Remove unused OFFSET_IN_PAGE() macro

From: David Miller <davem@davemloft.net>
Date: 2012-03-01 22:22:24

From: Roland Dreier <roland@kernel.org>
Date: Wed, 29 Feb 2012 22:40:46 -0800
From: Roland Dreier <redacted>

Signed-off-by: Roland Dreier <redacted>
Applied.

I assume you are aware of the same issue in the be2iscsi driver.

Re: [PATCH] be2net: Remove unused OFFSET_IN_PAGE() macro

From: Roland Dreier <roland@kernel.org>
Date: 2012-03-05 20:39:57

On Thu, Mar 1, 2012 at 2:22 PM, David Miller [off-list ref] wrote:
I assume you are aware of the same issue in the be2iscsi driver.
Yeah, patch already sent:
http://www.spinics.net/lists/linux-scsi/msg57754.html

but the SCSI maintainer is not as responsive as the networking one ;)

 - R.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help