On 02/14/2012 09:03 PM, Stephen Rothwell wrote:
Hi all,
Changes since 20120214:
on x86_64:
CC net/decnet/dn_nsp_in.o
In file included from /next/linux-next-20120215/net/decnet/dn_nsp_in.c:75:0:
/next/linux-next-20120215/include/net/dn.h:195:65: warning: 'struct flowidn' declared inside parameter list
/next/linux-next-20120215/include/net/dn.h:195:65: warning: its scope is only this definition or declaration, which is probably not what you want
/next/linux-next-20120215/drivers/misc/hpilo.c:722:13: warning: 'ilo_remove' defined but not used
/next/linux-next-20120215/include/net/dn.h: In function 'dn_sk_ports_copy':
/next/linux-next-20120215/include/net/dn.h:197:5: error: dereferencing pointer to incomplete type
/next/linux-next-20120215/include/net/dn.h:198:5: error: dereferencing pointer to incomplete type
In file included from /next/linux-next-20120215/net/decnet/dn_nsp_in.c:78:0:
/next/linux-next-20120215/include/net/dn_route.h: At top level:
/next/linux-next-20120215/include/net/dn_route.h:19:83: warning: 'struct flowidn' declared inside parameter list
/next/linux-next-20120215/include/net/dn_route.h:70:17: error: field 'fld' has incomplete type
make[3]: *** [net/decnet/dn_nsp_in.o] Error 1
Full randconfig file is attached.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
From: Randy Dunlap <redacted>
Date: Wed, 15 Feb 2012 11:52:03 -0800
On 02/14/2012 09:03 PM, Stephen Rothwell wrote:
quoted
Hi all,
Changes since 20120214:
on x86_64:
CC net/decnet/dn_nsp_in.o
In file included from /next/linux-next-20120215/net/decnet/dn_nsp_in.c:75:0:
/next/linux-next-20120215/include/net/dn.h:195:65: warning: 'struct flowidn' declared inside parameter list
I can't reproduce this in the net-next tree using your config but I can
certainly fix it, as follows :-)
--------------------
decnet: net/dn.h needs net/flow.h
Reported-by: Randy Dunlap <redacted>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
include/net/dn.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/net/dn.h b/include/net/dn.h
index 298521e..814af0b 100644
--- a/include/net/dn.h
+++ b/include/net/dn.h
@@ -3,6 +3,7 @@
#include <linux/dn.h>
#include <net/sock.h>
+#include <net/flow.h>
#include <asm/byteorder.h>
#include <asm/unaligned.h>
--
1.7.7.6
On 02/15/2012 01:38 PM, David Miller wrote:
From: Randy Dunlap <redacted>
Date: Wed, 15 Feb 2012 11:52:03 -0800
quoted
On 02/14/2012 09:03 PM, Stephen Rothwell wrote:
quoted
Hi all,
Changes since 20120214:
on x86_64:
CC net/decnet/dn_nsp_in.o
In file included from /next/linux-next-20120215/net/decnet/dn_nsp_in.c:75:0:
/next/linux-next-20120215/include/net/dn.h:195:65: warning: 'struct flowidn' declared inside parameter list
I can't reproduce this in the net-next tree using your config but I can
certainly fix it, as follows :-)
Yes, you fixed it. Thanks.
Acked-by: Randy Dunlap <redacted>
quoted hunk
--------------------
decnet: net/dn.h needs net/flow.h
Reported-by: Randy Dunlap <redacted>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
include/net/dn.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/net/dn.h b/include/net/dn.h
index 298521e..814af0b 100644
--- a/include/net/dn.h
+++ b/include/net/dn.h
@@ -3,6 +3,7 @@
#include <linux/dn.h>
#include <net/sock.h>
+#include <net/flow.h>
#include <asm/byteorder.h>
#include <asm/unaligned.h>
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***