[PATCH] mlx4: Fix kcalloc parameters swapped

Subsystems: mellanox mlx4 core vpi driver, networking drivers, the rest

STALE5295d

2 messages, 2 authors, 2012-02-13 · open the first message on its own page

[PATCH] mlx4: Fix kcalloc parameters swapped

From: Axel Lin <hidden>
Date: 2012-02-13 01:14:50

The first parameter should be "number of elements" and the second parameter
should be "element size".

Signed-off-by: Axel Lin <redacted>
---
 drivers/net/ethernet/mellanox/mlx4/eq.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
index 55d7bd4..8fa41f3 100644
--- a/drivers/net/ethernet/mellanox/mlx4/eq.c
+++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
@@ -815,8 +815,9 @@ int mlx4_init_eq_table(struct mlx4_dev *dev)
 	int err;
 	int i;
 
-	priv->eq_table.uar_map = kcalloc(sizeof *priv->eq_table.uar_map,
-					 mlx4_num_eq_uar(dev), GFP_KERNEL);
+	priv->eq_table.uar_map = kcalloc(mlx4_num_eq_uar(dev),
+					 sizeof *priv->eq_table.uar_map,
+					 GFP_KERNEL);
 	if (!priv->eq_table.uar_map) {
 		err = -ENOMEM;
 		goto err_out_free;
-- 
1.7.5.4

Re: [PATCH] mlx4: Fix kcalloc parameters swapped

From: David Miller <davem@davemloft.net>
Date: 2012-02-13 21:02:47

From: Axel Lin <redacted>
Date: Mon, 13 Feb 2012 09:14:39 +0800
The first parameter should be "number of elements" and the second parameter
should be "element size".

Signed-off-by: Axel Lin <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help