# Re: \[PATCH 24/50\] sis900: use dev\_hw\_addr\_random() instead of random\_ether\_addr()

- From: Daniele Venzano \<venza@brownhat.org\>
- Date: 2012-02-11 09:14:33 
- List: netdev
- Page: https://ratatoskr.run/netdev/2012/02/3821328
- Thread: https://ratatoskr.run/netdev/2012/02/3819974/t.md

```text
Il 08.02.2012 22:10, Danny Kukawka ha scritto:

> Use dev_hw_addr_random() instead of calling random_ether_addr()
> to set addr_assign_type correctly to NET_ADDR_RANDOM.

Acked-by: Daniele Venzano <venza@brownhat.org>

> Signed-off-by: Danny Kukawka <redacted>
> ---
>  drivers/net/ethernet/sis/sis900.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
> index c8efc70..cbd0343 100644
> --- a/drivers/net/ethernet/sis/sis900.c
> +++ b/drivers/net/ethernet/sis/sis900.c
> @@ -527,7 +527,7 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev,
>  		ret = sis900_get_mac_addr(pci_dev, net_dev);
>  
>  	if (!ret || !is_valid_ether_addr(net_dev->dev_addr)) {
> -		random_ether_addr(net_dev->dev_addr);
> +		dev_hw_addr_random(net_dev, net_dev->dev_addr);
>  		printk(KERN_WARNING "%s: Unreadable or invalid MAC address,"
>  				"using random generated one\n", dev_name);
>  	}
```