# RE: \[PATCH 08/50\] bnx2x: use dev\_hw\_addr\_random() instead of random\_ether\_addr()

- From: David Laight \<hidden\>
- Date: 2012-02-09 10:00:06 
- List: netdev
- Page: https://ratatoskr.run/netdev/2012/02/3820211
- Thread: https://ratatoskr.run/netdev/2012/02/3819974/t.md

```text
 
> +	if (dev->addr_assign_type & NET_ADDR_RANDOM)
> +		dev->addr_assign_type ^= NET_ADDR_RANDOM;

Why not just:
	dev->addr_assign_type &= ~NET_ADDR_RANDOM;
the cache is probably dirty and it won't be a critical path.

	David
```