[PATCH] Net: caifdev is never used in net/caif/caif_dev.c::transmit() - remove it.

Subsystems: networking [general], the rest

STALE5304d

2 messages, 2 authors, 2012-02-05 · open the first message on its own page

[PATCH] Net: caifdev is never used in net/caif/caif_dev.c::transmit() - remove it.

From: Jesper Juhl <hidden>
Date: 2012-02-05 22:50:22

Signed-off-by: Jesper Juhl <redacted>
---
 net/caif/caif_dev.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
index 82c5706..aa6f716 100644
--- a/net/caif/caif_dev.c
+++ b/net/caif/caif_dev.c
@@ -162,7 +162,6 @@ void caif_flow_cb(struct sk_buff *skb)
 static int transmit(struct cflayer *layer, struct cfpkt *pkt)
 {
 	int err, high = 0, qlen = 0;
-	struct caif_dev_common *caifdev;
 	struct caif_device_entry *caifd =
 	    container_of(layer, struct caif_device_entry, layer);
 	struct sk_buff *skb;
@@ -174,7 +173,6 @@ static int transmit(struct cflayer *layer, struct cfpkt *pkt)
 	skb->dev = caifd->netdev;
 	skb_reset_network_header(skb);
 	skb->protocol = htons(ETH_P_CAIF);
-	caifdev = netdev_priv(caifd->netdev);
 
 	/* Check if we need to handle xoff */
 	if (likely(caifd->netdev->tx_queue_len == 0))
-- 
1.7.9


-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH] Net: caifdev is never used in net/caif/caif_dev.c::transmit() - remove it.

From: David Miller <davem@davemloft.net>
Date: 2012-02-05 22:54:15

From: Jesper Juhl <redacted>
Date: Sun, 5 Feb 2012 23:50:46 +0100 (CET)
Signed-off-by: Jesper Juhl <redacted>
Applied.

I changed the subject prefix to "caif: " and the one for your previous
patch to "decnet: "  Please don't put that "Net, " thing there.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help