RE: [PATCH net-next] mlx4_en: dont change mac_header on xmit

From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
Sent: Saturday, February 25, 2012 12:51 PM

A driver xmit function is not allowed to change skb without special
care.

mlx4_en_xmit() should not call skb_reset_mac_header() and instead should
use skb->data to access ethernet header.

This removes a dumb test : if (ethh && ethh->h_dest)

Also remove this slow mlx4_en_mac_to_u64() call, we can use
get_unaligned() to get faster code.

Signed-off-by: Eric Dumazet <redacted>
Cc: Yevgeny Petrilin <redacted>
---
Please test this patch before we can commit it, thanks !

Tested and approved, thanks.
--
Eugenia Emantayev

From: Eugenia Emantayev <redacted>
Date: Sun, 26 Feb 2012 19:12:12 +0000

From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
Sent: Saturday, February 25, 2012 12:51 PM

quoted

A driver xmit function is not allowed to change skb without special
care.

mlx4_en_xmit() should not call skb_reset_mac_header() and instead should
use skb->data to access ethernet header.

This removes a dumb test : if (ethh && ethh->h_dest)

Also remove this slow mlx4_en_mac_to_u64() call, we can use
get_unaligned() to get faster code.

Signed-off-by: Eric Dumazet <redacted>
Cc: Yevgeny Petrilin <redacted>
---
Please test this patch before we can commit it, thanks !

Tested and approved, thanks.
--

Applied.