# Re: \[PATCH\] ppp: fix 'ppp\_mp\_reconstruct bad seq' errors

- From: David Miller \<davem@davemloft.net\>
- Date: 2012-02-24 22:52:30 
- List: netdev
- Page: https://ratatoskr.run/netdev/2012/02/10889398
- Thread: https://ratatoskr.run/netdev/2012/02/10889376/t.md

```text
From: Ben McKeegan <redacted>
Date: Fri, 24 Feb 2012 16:33:56 +0000 (GMT)

> 
> This patch fixes a (mostly cosmetic) bug introduced by the patch
> 'ppp: Use SKB queue abstraction interfaces in fragment processing'
> found here: http://www.spinics.net/lists/netdev/msg153312.html
> 
> The above patch rewrote and moved the code responsible for cleaning
> up discarded fragments but the new code does not catch every case
> where this is necessary.  This results in some discarded fragments
> remaining in the queue, and triggering a 'bad seq' error on the
> subsequent call to ppp_mp_reconstruct.  Fragments are discarded
> whenever other fragments of the same frame have been lost.
> This can generate a lot of unwanted and misleading log messages.
> 
> This patch also adds additional detail to the debug logging to
> make it clearer which fragments were lost and which other fragments
> were discarded as a result of losses. (Run pppd with 'kdebug 1'
> option to enable debug logging.)
> 
> Signed-off-by: Ben McKeegan <redacted>

I'll apply this, thanks.
```