# Re: \[PATCH\] netns: fix net\_alloc\_generic()

- From: Eric W. Biederman \<hidden\>
- Date: 2012-01-26 23:54:46 
- List: netdev
- Page: https://ratatoskr.run/netdev/2012/01/3814215
- Thread: https://ratatoskr.run/netdev/2012/01/3814215/t.md

```text
David Miller [ref] writes:

> From: <redacted> (Eric W. Biederman)
> Date: Thu, 26 Jan 2012 14:57:02 -0800
>
>> It is not a chicken and egg problem.  It is a bug in caif.
>> caif is claiming to be a network device when it is acting as a subsytem.
>> That means it is being initialized too late.
>> 
>> Untested but this should trivially fix the problem, and a bunch
>> of others of the same ilk.
>> 
>> It is not safe to shutdown subsystems until all of the devices
>> are gone, otherwise there will be problems with packets in flight.
>
> If you guys can agree that this is the better fix, and we can
> get testing showing that it works, I'll revert Eric D.'s patch
> and apply the final version of this one.

Eric D.'s change is correct, but it is just an optimization of
net_assign_generic.  Eric D.'s change is not a bug fix.

Tested fix in a moment.

Eric
```