[patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size

STALE5315d

2 messages, 2 authors, 2012-01-26 · open the first message on its own page

[patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size

From: Stefan Gula <hidden>
Date: 2012-01-26 21:04:36

From: Stefan Gula <redacted>

Setting link parameters on a netdevice changes the value
of if_nlmsg_size(), therefore it is necessary to recalculate
min_ifinfo_dump_size.

Signed-off-by: Stefan Gula <redacted>

---
V2-changelog: adjusted commit message
--- linux-3.2.1-orig/net/core/rtnetlink.c	2012-01-12 20:42:45.000000000 +0100
+++ linux/net/core/rtnetlink.c	2012-01-24 14:26:58.083219352 +0100
@@ -1506,6 +1506,9 @@ errout:
 
 	if (send_addr_notify)
 		call_netdevice_notifiers(NETDEV_CHANGEADDR, dev);
+	min_ifinfo_dump_size = max_t(u16, if_nlmsg_size(dev),
+					min_ifinfo_dump_size);
+
 	return err;
 }

Re: [patch v2, kernel 3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size

From: David Miller <davem@davemloft.net>
Date: 2012-01-26 21:37:29

From: Stefan Gula <redacted>
Date: Thu, 26 Jan 2012 22:01:06 +0100 (CET)
From: Stefan Gula <redacted>

Setting link parameters on a netdevice changes the value
of if_nlmsg_size(), therefore it is necessary to recalculate
min_ifinfo_dump_size.

Signed-off-by: Stefan Gula <redacted>
Applied, but:
+	min_ifinfo_dump_size = max_t(u16, if_nlmsg_size(dev),
+					min_ifinfo_dump_size);
+
The second line is not properly indented, the first non-space
character should line up with the first column after the
openning parenthesis on the previous line.

I fixed this up, but really this was a lot of tooth pulling to
get you to post this patch correctly.  You cannot consume this
much maintainer and reviewer resources in the future.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help