# \[PATCH net-next\] ipv6: fix RFC5722 comment - Subsystems: NETWORKING \[GENERAL\], NETWORKING \[IPv4/IPv6\], THE REST - Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern, Ido Schimmel, Linus Torvalds - List: netdev - 3 messages, 3 authors - Page: https://ratatoskr.run/netdev/2012/01/10887482/t ## \[PATCH net-next\] ipv6: fix RFC5722 comment - From: Eric Dumazet \ - Date: 2012-01-30 14:29:28 - Message: https://ratatoskr.run/netdev/2012/01/10887482.md ```text RFC5722 Section 4 was amended by Errata 3089 Our implementation did the right thing anyway... Signed-off-by: Eric Dumazet Cc: Nicolas Dichtel --- net/ipv6/reassembly.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c index b69fae7..9447bd6 100644 --- a/net/ipv6/reassembly.c +++ b/net/ipv6/reassembly.c @@ -336,12 +336,11 @@ static int ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb, } found: - /* RFC5722, Section 4: - * When reassembling an IPv6 datagram, if + /* RFC5722, Section 4, amended by Errata ID : 3089 + * When reassembling an IPv6 datagram, if * one or more its constituent fragments is determined to be an * overlapping fragment, the entire datagram (and any constituent - * fragments, including those not yet received) MUST be silently - * discarded. + * fragments) MUST be silently discarded. */ /* Check for overlap with preceding fragment. */ ``` ## Re: \[PATCH net-next\] ipv6: fix RFC5722 comment - From: Nicolas Dichtel \ - Date: 2012-01-30 14:42:28 - Message: https://ratatoskr.run/netdev/2012/01/10887484.md ```text Le 30/01/2012 15:29, Eric Dumazet a écrit : > RFC5722 Section 4 was amended by Errata 3089 > > Our implementation did the right thing anyway... > > Signed-off-by: Eric Dumazet > Cc: Nicolas Dichtel Acked-by: Nicolas Dichtel > --- > net/ipv6/reassembly.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c > index b69fae7..9447bd6 100644 > --- a/net/ipv6/reassembly.c > +++ b/net/ipv6/reassembly.c > @@ -336,12 +336,11 @@ static int ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb, > } > > found: > - /* RFC5722, Section 4: > - * When reassembling an IPv6 datagram, if > + /* RFC5722, Section 4, amended by Errata ID : 3089 > + * When reassembling an IPv6 datagram, if Identation was an exact copy of the original rfc (not changed by the errata), but it's a detail ;-) Regards, Nicolas > * one or more its constituent fragments is determined to be an > * overlapping fragment, the entire datagram (and any constituent > - * fragments, including those not yet received) MUST be silently > - * discarded. > + * fragments) MUST be silently discarded. > */ > > /* Check for overlap with preceding fragment. */ ``` ## Re: \[PATCH net-next\] ipv6: fix RFC5722 comment - From: David Miller \ - Date: 2012-01-30 17:59:12 - Message: https://ratatoskr.run/netdev/2012/01/10887537.md ```text From: Eric Dumazet Date: Mon, 30 Jan 2012 15:29:24 +0100 > RFC5722 Section 4 was amended by Errata 3089 > > Our implementation did the right thing anyway... > > Signed-off-by: Eric Dumazet > Cc: Nicolas Dichtel Applied, thanks Eric. ```