[PATCH] net: explicitly add jump_label.h header to sock.h

Subsystems: networking [general], networking [sockets], the rest

STALE5341d

2 messages, 2 authors, 2012-01-26 · open the first message on its own page

[PATCH] net: explicitly add jump_label.h header to sock.h

From: Glauber Costa <hidden>
Date: 2012-01-26 22:09:47

Commit 36a1211970193ce215de50ed1e4e1272bc814df1 removed linux/module.h
include statement from one of the headers that end up in net/sock.h.
It was providing us with static_branch() definition implicitly, so
after its removal the build got broken.

To fix this, and avoid having this happening in the future,
let me do the right thing and include linux/jump_label.h
explicitly in sock.h.

Signed-off-by: Glauber Costa <redacted>
Reported-by: Randy Dunlap <redacted>
CC: David S. Miller <davem@davemloft.net>
---
 include/net/sock.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/net/sock.h b/include/net/sock.h
index 4c69ac1..91c1c8b 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -55,6 +55,7 @@
 #include <linux/uaccess.h>
 #include <linux/memcontrol.h>
 #include <linux/res_counter.h>
+#include <linux/jump_label.h>
 
 #include <linux/filter.h>
 #include <linux/rculist_nulls.h>
-- 
1.7.7.4

Re: [PATCH] net: explicitly add jump_label.h header to sock.h

From: David Miller <davem@davemloft.net>
Date: 2012-01-26 22:31:49

From: Glauber Costa <redacted>
Date: Fri, 27 Jan 2012 02:09:28 +0400
Commit 36a1211970193ce215de50ed1e4e1272bc814df1 removed linux/module.h
include statement from one of the headers that end up in net/sock.h.
It was providing us with static_branch() definition implicitly, so
after its removal the build got broken.

To fix this, and avoid having this happening in the future,
let me do the right thing and include linux/jump_label.h
explicitly in sock.h.

Signed-off-by: Glauber Costa <redacted>
Reported-by: Randy Dunlap <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help