[PATCH] 8139cp: fix missing napi_gro_flush.

Subsystems: networking drivers, the rest

STALE5330d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2012-01-09 · open the first message on its own page

[PATCH] 8139cp: fix missing napi_gro_flush.

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2012-01-08 23:51:00

The driver uses __napi_complete and napi_gro_receive. Without it, the
driver hits the BUG_ON(n->gro_list) assertion hard in __napi_complete.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Tested-by: Marin Glibic <redacted>
---

 This is a candidate for -stable.

 drivers/net/ethernet/realtek/8139cp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c
index cc6b391..abc7907 100644
--- a/drivers/net/ethernet/realtek/8139cp.c
+++ b/drivers/net/ethernet/realtek/8139cp.c
@@ -563,6 +563,7 @@ rx_next:
 		if (cpr16(IntrStatus) & cp_rx_intr_mask)
 			goto rx_status_loop;
 
+		napi_gro_flush(napi);
 		spin_lock_irqsave(&cp->lock, flags);
 		__napi_complete(napi);
 		cpw16_f(IntrMask, cp_intr_mask);
-- 
1.7.6.4

Re: [PATCH] 8139cp: fix missing napi_gro_flush.

From: David Miller <davem@davemloft.net>
Date: 2012-01-09 03:22:15

From: Francois Romieu <romieu@fr.zoreil.com>
Date: Mon, 9 Jan 2012 00:41:33 +0100
The driver uses __napi_complete and napi_gro_receive. Without it, the
driver hits the BUG_ON(n->gro_list) assertion hard in __napi_complete.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Tested-by: Marin Glibic <redacted>
Applied, thanks.
---

 This is a candidate for -stable.
Queued up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help