[PATCH 1/2] bna: make ethtool_ops and strings const

STALE5332d

3 messages, 3 authors, 2012-01-05 · open the first message on its own page

[PATCH 1/2] bna: make ethtool_ops and strings const

From: Stephen Hemminger <hidden>
Date: 2012-01-04 23:03:59 

Signed-off-by: Stephen Hemminger <redacted>


--- a/drivers/net/ethernet/brocade/bna/bnad_ethtool.c	2011-12-23 21:06:15.724436897 -0800
+++ b/drivers/net/ethernet/brocade/bna/bnad_ethtool.c	2012-01-04 14:22:02.403250833 -0800
@@ -38,7 +38,7 @@
 	sizeof(struct bnad_drv_stats) / sizeof(u64) +		\
 	offsetof(struct bfi_enet_stats, rxf_stats[0]) / sizeof(u64))
 
-static char *bnad_net_stats_strings[BNAD_ETHTOOL_STATS_NUM] = {
+static const char *bnad_net_stats_strings[BNAD_ETHTOOL_STATS_NUM] = {
 	"rx_packets",
 	"tx_packets",
 	"rx_bytes",
@@ -1072,7 +1072,7 @@ done:
 	return ret;
 }
 
-static struct ethtool_ops bnad_ethtool_ops = {
+static const struct ethtool_ops bnad_ethtool_ops = {
 	.get_settings = bnad_get_settings,
 	.set_settings = bnad_set_settings,
 	.get_drvinfo = bnad_get_drvinfo,

Re: [PATCH 1/2] bna: make ethtool_ops and strings const

From: David Miller <davem@davemloft.net>
Date: 2012-01-05 18:24:47 

From: Stephen Hemminger <redacted>
Date: Wed, 04 Jan 2012 15:02:23 -0800

Signed-off-by: Stephen Hemminger <redacted>
Applied.

RE: [PATCH 1/2] bna: make ethtool_ops and strings const

From: Rasesh Mody <hidden>
Date: 2012-01-05 18:29:05 

From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, January 05, 2012 10:24 AM

From: Stephen Hemminger <redacted>
Date: Wed, 04 Jan 2012 15:02:23 -0800
quoted
Signed-off-by: Stephen Hemminger <redacted>
Applied.
Thanks Stephen, David!
--Rasesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help