[PATCH v2] drivers/net/usb/asix: fixed asix_get_wol reported wrong wol status issue

Subsystems: networking drivers, the rest, usb networking drivers

STALE5378d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2011-12-23 · open the first message on its own page

[PATCH v2] drivers/net/usb/asix: fixed asix_get_wol reported wrong wol status issue

From: allan <hidden>
Date: 2011-12-23 06:39:16

Fixed the asix_get_wol() routine reported wrong wol status issue. 

Signed-off-by: Allan Chou <redacted>
Tested-by: Eugene <redacted>; Allan Chou <redacted>
---
This fix had been verified on x86 Linux kernel 3.0.0-12-generic system with AX88772A/AX88772/Belkin AX88178 USB dongles, and the wol function works fine (can be waked up by receiving the magic packets).
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
--- a/drivers/net/usb/asix.c	2011-12-15 14:01:49.000000000 +0800
+++ b/drivers/net/usb/asix.c	2011-12-22 18:20:39.000000000 +0800
@@ -36,7 +36,7 @@
 #include <linux/usb/usbnet.h>
 #include <linux/slab.h>
 
-#define DRIVER_VERSION "08-Nov-2011"
+#define DRIVER_VERSION "22-Dec-2011"
 #define DRIVER_NAME "asix"
 
 /* ASIX AX8817X based USB 2.0 Ethernet Devices */
@@ -689,6 +689,10 @@ asix_get_wol(struct net_device *net, str
 	}
 	wolinfo->supported = WAKE_PHY | WAKE_MAGIC;
 	wolinfo->wolopts = 0;
+	if (opt & AX_MONITOR_LINK)
+		wolinfo->wolopts |= WAKE_PHY;
+	if (opt & AX_MONITOR_MAGIC)
+		wolinfo->wolopts |= WAKE_MAGIC;
 }
 
 static int

Re: [PATCH v2] drivers/net/usb/asix: fixed asix_get_wol reported wrong wol status issue

From: David Miller <davem@davemloft.net>
Date: 2011-12-23 21:53:09

From: "allan" <redacted>
Date: Fri, 23 Dec 2011 14:38:51 +0800
Fixed the asix_get_wol() routine reported wrong wol status issue. 

Signed-off-by: Allan Chou <redacted>
Tested-by: Eugene <redacted>; Allan Chou <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help