[PATCH net] ipv4: flush route cache after change accept_local

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE5378d

4 messages, 2 authors, 2011-12-02 · open the first message on its own page

[PATCH net] ipv4: flush route cache after change accept_local

From: Weiping Pan <hidden>
Date: 2011-12-01 11:46:27

After reset ipv4_devconf->data[IPV4_DEVCONF_ACCEPT_LOCAL] to 0,
we should flash route cache, or it will continue receive packets with local
source address, which should be dropped.

Signed-off-by: Weiping Pan <redacted>
---
 net/ipv4/devinet.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index c6b5092..de1a772 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c

@@ -1490,7 +1490,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write,
 			     void __user *buffer,
 			     size_t *lenp, loff_t *ppos)
 {
+	int old_value = *(int *)ctl->data;
 	int ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
+	int new_value = *(int *)ctl->data;
 
 	if (write) {
 		struct ipv4_devconf *cnf = ctl->extra1;

@@ -1501,6 +1503,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write,
 
 		if (cnf == net->ipv4.devconf_dflt)
 			devinet_copy_dflt_conf(net, i);
+		if ((i == IPV4_DEVCONF_ACCEPT_LOCAL - 1))
+			if ((new_value == 0) && (old_value != 0))
+				rt_cache_flush(net, 0);
 	}
 
 	return ret;

-- 
1.7.4

Re: [PATCH net] ipv4: flush route cache after change accept_local

From: David Miller <davem@davemloft.net>
Date: 2011-12-01 17:54:44

From: Weiping Pan <redacted>
Date: Thu,  1 Dec 2011 19:47:56 +0800

+		if ((i == IPV4_DEVCONF_ACCEPT_LOCAL - 1))

I don't think the extra parenthesis is appropriate here, please only use
one set of them.

Thanks.

[PATCH] ipv4: flush route cache after change accept_local

From: Weiping Pan <hidden>
Date: 2011-12-02 01:45:36

After reset ipv4_devconf->data[IPV4_DEVCONF_ACCEPT_LOCAL] to 0,
we should flush route cache, or it will continue receive packets with local
source address, which should be dropped.

Signed-off-by: Weiping Pan <redacted>
---
 net/ipv4/devinet.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index c6b5092..65f01dc 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c

@@ -1490,7 +1490,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write,
 			     void __user *buffer,
 			     size_t *lenp, loff_t *ppos)
 {
+	int old_value = *(int *)ctl->data;
 	int ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
+	int new_value = *(int *)ctl->data;
 
 	if (write) {
 		struct ipv4_devconf *cnf = ctl->extra1;

@@ -1501,6 +1503,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write,
 
 		if (cnf == net->ipv4.devconf_dflt)
 			devinet_copy_dflt_conf(net, i);
+		if (i == IPV4_DEVCONF_ACCEPT_LOCAL - 1)
+			if ((new_value == 0) && (old_value != 0))
+				rt_cache_flush(net, 0);
 	}
 
 	return ret;

-- 
1.7.4

Re: [PATCH] ipv4: flush route cache after change accept_local

From: David Miller <davem@davemloft.net>
Date: 2011-12-02 02:49:27

From: Weiping Pan <redacted>
Date: Fri,  2 Dec 2011 09:47:06 +0800

After reset ipv4_devconf->data[IPV4_DEVCONF_ACCEPT_LOCAL] to 0,
we should flush route cache, or it will continue receive packets with local
source address, which should be dropped.

Signed-off-by: Weiping Pan <redacted>

Applied, thanks.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help