# Re: \[net-next 1/6\] e1000e: Avoid wrong check on TX hang

- From: Jeff Kirsher \<hidden\>
- Date: 2011-12-04 07:28:37 
- List: netdev
- Page: https://ratatoskr.run/netdev/2011/12/10884144
- Thread: https://ratatoskr.run/netdev/2011/12/10884117/t.md

```text
On Sat, 2011-12-03 at 19:26 -0800, David Miller wrote:
> From: Jeff Kirsher <redacted>
> Date: Sat,  3 Dec 2011 03:44:26 -0800
> 
> > +	if ((!adapter->tx_hang_recheck) &&
> 
> Excessive parenthesis, please remove.
> 
> > +		adapter->tx_hang_recheck = 1;
> 
> This variable is a bool, set it to true or false.
> 
> > +			adapter->tx_hang_recheck = 0;
> 
> Likewise.
> 
> > +	adapter->tx_hang_recheck = 0;
> 
> Likewise.

Michael/Flavio -

To expedite this patch, I can make the changes that Dave is requesting
and re-submit v2 of the patch, if that is ok with you.

-Jeff
```

## Attachments

- [signature.asc](https://ratatoskr.run/netdev/2011/12/10884144/attachment/0) (application/pgp-signature, 836 bytes)