[PATCH] ks8*/ksz8*: Casting (void *) value returned by kmalloc is useless

STALE5406d

2 messages, 2 authors, 2011-11-21 · open the first message on its own page

[PATCH] ks8*/ksz8*: Casting (void *) value returned by kmalloc is useless

From: Thomas Meyer <hidden>
Date: 2011-11-18 09:32:35

The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

Signed-off-by: Thomas Meyer <redacted>
---

diff -u -p a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c
--- a/drivers/net/ethernet/micrel/ks8851_mll.c 2011-11-07 19:37:59.170122280 +0100
+++ b/drivers/net/ethernet/micrel/ks8851_mll.c 2011-11-08 09:00:03.544702580 +0100
@@ -1500,8 +1500,7 @@ static int ks_hw_init(struct ks_net *ks)
 	ks->all_mcast = 0;
 	ks->mcast_lst_size = 0;
 
-	ks->frame_head_info = (struct type_frame_head *) \
-		kmalloc(MHEADER_SIZE, GFP_KERNEL);
+	ks->frame_head_info = kmalloc(MHEADER_SIZE, GFP_KERNEL);
 	if (!ks->frame_head_info) {
 		pr_err("Error: Fail to allocate frame memory\n");
 		return false;

Re: [PATCH] ks8*/ksz8*: Casting (void *) value returned by kmalloc is useless

From: David Miller <davem@davemloft.net>
Date: 2011-11-21 20:07:15

From: Thomas Meyer <redacted>
Date: Thu, 17 Nov 2011 23:43:40 +0100
The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

Signed-off-by: Thomas Meyer <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help