[PATCH] net/ll_temac: FIX : Wait for indirect wait to end

Subsystems: networking drivers, the rest, xilinx ll temac ethernet driver

STALE5445d

2 messages, 2 authors, 2011-11-09 · open the first message on its own page

[PATCH] net/ll_temac: FIX : Wait for indirect wait to end

From: Ricardo Ribalda Delgado <hidden>
Date: 2011-11-08 09:40:35

While tracing down a connectivity problem on the temac I connected a
probe to the Cross bar irq, and it was triggered when doing
ifdown->ifup.

This is fixed once waiting for the indirect write to end. Since it is
not on the hot path there is no performance loss.

Signed-off-by: Ricardo Ribalda Delgado <redacted>
---
 drivers/net/ethernet/xilinx/ll_temac_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 4d1658e..cf59dac 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -114,6 +114,7 @@ void temac_indirect_out32(struct temac_local *lp, int reg, u32 value)
 		return;
 	temac_iow(lp, XTE_LSW0_OFFSET, value);
 	temac_iow(lp, XTE_CTL0_OFFSET, CNTLREG_WRITE_ENABLE_MASK | reg);
+	temac_indirect_busywait(lp);
 }
 
 /**
-- 
1.7.7.1

Re: [PATCH] net/ll_temac: FIX : Wait for indirect wait to end

From: David Miller <davem@davemloft.net>
Date: 2011-11-09 20:40:17

From: Ricardo Ribalda Delgado <redacted>
Date: Tue,  8 Nov 2011 10:39:57 +0100
While tracing down a connectivity problem on the temac I connected a
probe to the Cross bar irq, and it was triggered when doing
ifdown->ifup.

This is fixed once waiting for the indirect write to end. Since it is
not on the hot path there is no performance loss.

Signed-off-by: Ricardo Ribalda Delgado <redacted>
Also applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help