[PATCH 1/2] bridge: leave carrier on for empty bridge

STALE5452d

2 messages, 2 authors, 2011-10-06 · open the first message on its own page

[PATCH 1/2] bridge: leave carrier on for empty bridge

From: Stephen Hemminger <hidden>
Date: 2011-10-04 04:16:52

This resolves a regression seen by some users of bridging.
Some users use the bridge like a dummy device. 
They expect to be able to put an IPv6 address on the device
with no ports attached. Although there are better ways of doing
this, there is no reason to not allow it.

Note: the bridge still will reflect the state of ports in the
bridge if there are any added.

Signed-off-by: Stephen Hemminger <redacted>

---
This fix needs to go to stable as well since it has
been reported as a regression.

--- a/net/bridge/br_device.c	2011-09-01 08:52:27.596631192 -0700
+++ b/net/bridge/br_device.c	2011-09-01 09:01:03.256611801 -0700
@@ -91,7 +91,6 @@ static int br_dev_open(struct net_device
 {
 	struct net_bridge *br = netdev_priv(dev);
 
-	netif_carrier_off(dev);
 	netdev_update_features(dev);
 	netif_start_queue(dev);
 	br_stp_enable_bridge(br);
@@ -108,8 +107,6 @@ static int br_dev_stop(struct net_device
 {
 	struct net_bridge *br = netdev_priv(dev);
 
-	netif_carrier_off(dev);
-
 	br_stp_disable_bridge(br);
 	br_multicast_stop(br);
 

Re: [PATCH 1/2] bridge: leave carrier on for empty bridge

From: David Miller <davem@davemloft.net>
Date: 2011-10-06 19:28:17

From: Stephen Hemminger <redacted>
Date: Mon, 03 Oct 2011 21:14:45 -0700
This resolves a regression seen by some users of bridging.
Some users use the bridge like a dummy device. 
They expect to be able to put an IPv6 address on the device
with no ports attached. Although there are better ways of doing
this, there is no reason to not allow it.

Note: the bridge still will reflect the state of ports in the
bridge if there are any added.

Signed-off-by: Stephen Hemminger <redacted>
Applied to 'net' and queued up for -stable.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help