DORMANTno replies

[iproute2 PATCH 09/11] Fix file descriptor leak on error in read_mroute_list()

From: Thomas Jarosch <hidden>
Date: 2011-10-03 15:31:54
Subsystem: the rest · Maintainer: Linus Torvalds

Detected by cppcheck.

Signed-off-by: Thomas Jarosch <redacted>
---
 ip/ipmroute.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/ip/ipmroute.c b/ip/ipmroute.c
index f033349..945727d 100644
--- a/ip/ipmroute.c
+++ b/ip/ipmroute.c
@@ -85,8 +85,10 @@ static void read_mroute_list(FILE *ofp)
 	if (!fp)
 		return;
 
-	if (!fgets(buf, sizeof(buf), fp))
+	if (!fgets(buf, sizeof(buf), fp)) {
+		fclose(fp);
 		return;
+	}
 
 	while (fgets(buf, sizeof(buf), fp)) {
 		inet_prefix maddr, msrc;
-- 
1.7.4.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help