# Re: \[patch net-next-2.6\] net: consolidate and fix ethtool\_ops-\>get\_settings calling

- From: David Miller \<hidden\>
- Date: 2011-09-15 21:33:39 
- List: netdev
- Page: https://ratatoskr.run/netdev/2011/09/6694191
- Thread: https://ratatoskr.run/netdev/2011/09/6694132/t.md

```text
From: Jiri Pirko <redacted>
Date: Thu,  1 Sep 2011 21:28:24 +0200

> This patch does several things:
> - introduces __ethtool_get_settings which is called from ethtool code and
>   from dev_ethtool_get_settings() as well.
> - dev_ethtool_get_settings() becomes rtnl wrapper for
>   __ethtool_get_settings()
> - changes calling in drivers so rtnl locking is respected. In
>   iboe_get_rate was previously ->get_settings() called unlocked. This
>   fixes it
> - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create()
>   so bnx2fc_if_create() and fcoe_if_create() are called locked as they
>   are from other places.
> - prb_calc_retire_blk_tmo() in af_packet.c was not calling get_settings
>   with rtnl_lock. So use dev_ethtool_get_settings here.
> - use __ethtool_get_settings() in bonding code
> 
> Signed-off-by: Jiri Pirko <redacted>

Applied, thanks.
```
