[PATCH] ipv6-multicast: Fix memory leak in IPv6 multicast.

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE5367d

3 messages, 2 authors, 2012-02-02 · open the first message on its own page

[PATCH] ipv6-multicast: Fix memory leak in IPv6 multicast.

From: <hidden>
Date: 2011-09-23 23:11:09

From: Ben Greear <redacted>

If reg_vif_xmit cannot find a routing entry, be sure to
free the skb before returning the error.

Signed-off-by: Ben Greear <redacted>
---
:100644 100644 82a8099... e9a8df9... M	net/ipv6/ip6mr.c
 net/ipv6/ip6mr.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
index 82a8099..e9a8df9 100644
--- a/net/ipv6/ip6mr.c
+++ b/net/ipv6/ip6mr.c
@@ -696,8 +696,10 @@ static netdev_tx_t reg_vif_xmit(struct sk_buff *skb,
 	int err;
 
 	err = ip6mr_fib_lookup(net, &fl6, &mrt);
-	if (err < 0)
+	if (err < 0) {
+		kfree_skb(skb);
 		return err;
+	}
 
 	read_lock(&mrt_lock);
 	dev->stats.tx_bytes += skb->len;
-- 
1.7.3.4

Re: [PATCH] ipv6-multicast: Fix memory leak in IPv6 multicast.

From: David Miller <davem@davemloft.net>
Date: 2011-09-27 19:34:07

From: greearb@candelatech.com
Date: Fri, 23 Sep 2011 16:11:01 -0700
From: Ben Greear <redacted>

If reg_vif_xmit cannot find a routing entry, be sure to
free the skb before returning the error.

Signed-off-by: Ben Greear <redacted>
Applied.

Re: [PATCH] ipv6-multicast: Fix memory leak in IPv6 multicast.

From: Ben Greear <hidden>
Date: 2012-02-02 17:27:19

On 09/27/2011 12:34 PM, David Miller wrote:
From: greearb@candelatech.com
Date: Fri, 23 Sep 2011 16:11:01 -0700
quoted
From: Ben Greear<redacted>

If reg_vif_xmit cannot find a routing entry, be sure to
free the skb before returning the error.

Signed-off-by: Ben Greear<redacted>
Applied.
This one has not made it to 3.0 stable either.

Ben

-- 
Ben Greear [off-list ref]
Candela Technologies Inc  http://www.candelatech.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help