Re: pull request: batman-adv 2011-09-08

On Thursday, September 22, 2011 02:05:39 David Miller wrote:

From: Marek Lindner <redacted>
Date: Thu, 22 Sep 2011 01:39:26 +0200

quoted

 To ensure a smooth transition and efficient testing later, we
 decided to offer a choice of routing algorithm but have not
 come to a final decision on how to design this choice yet. It
 either will be a compile time option, a module parameter or a
 runtime switch. Any suggestions / best practice tips ?

What do you mean by "algorithm"?  Do you mean the implementation
of the data-structure used to perform lookups?

We had two data structures for our main routing table lookup
implementation in ipv4, this was a mistake.  We spent the next couple
years maintaining two pieces of code, and finally investing lots of
effort to eliminate the older code.

No, the data structures for the routing lookups remain the same but there will 
be more than one way to fill them with data. You will only use one "filling 
algorithm" at a time, so you will need to select the one you want.

Regards,
Marek

From: Marek Lindner <redacted>
Date: Thu, 22 Sep 2011 02:10:04 +0200

No, the data structures for the routing lookups remain the same but there will 
be more than one way to fill them with data. You will only use one "filling 
algorithm" at a time, so you will need to select the one you want.

Extend the userspace interface for adding route entries with a boolean
flag.  You're using netlink right?  If so, this should be trivial by
simply adding a flags attribute if you don't have one already.