IRDA: Fix global type conflicts in net/irda/irsysctl.c

Subsystems: networking [general], the rest

2 messages, 2 authors, 2011-09-16 · open the first message on its own page

IRDA: Fix global type conflicts in net/irda/irsysctl.c

From: Andi Kleen <hidden>
Date: 2011-09-16 17:32:52

The externs here didn't agree with the declarations in qos.c.

Better would be probably to move this into a header, but since it's
common practice to have naked externs with sysctls I left it for now.

Cc: samuel@sortiz.org
Signed-off-by: Andi Kleen <redacted>
diff --git a/net/irda/irsysctl.c b/net/irda/irsysctl.c
index d0b70da..be22ad2 100644
--- a/net/irda/irsysctl.c
+++ b/net/irda/irsysctl.c
@@ -40,9 +40,9 @@ extern int  sysctl_slot_timeout;
 extern int  sysctl_fast_poll_increase;
 extern char sysctl_devname[];
 extern int  sysctl_max_baud_rate;
-extern int  sysctl_min_tx_turn_time;
-extern int  sysctl_max_tx_data_size;
-extern int  sysctl_max_tx_window;
+extern unsigned  sysctl_min_tx_turn_time;
+extern unsigned  sysctl_max_tx_data_size;
+extern unsigned  sysctl_max_tx_window;
 extern int  sysctl_max_noreply_time;
 extern int  sysctl_warn_noreply_time;
 extern int  sysctl_lap_keepalive_time;
-- 
ak@linux.intel.com -- Speaking for myself only

Re: IRDA: Fix global type conflicts in net/irda/irsysctl.c

From: David Miller <davem@davemloft.net>
Date: 2011-09-16 18:53:15

Please use "unsigned int" rather than plain "unsigned", and yes
that means you might have to fix up the other instances likewise.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help