4 messages, 3 authors, 2011-08-30 · open the first message on its own page
From: Randy Dunlap <hidden>
Date: 2011-08-29 20:28:06
On Mon, 29 Aug 2011 16:19:07 +1000 Stephen Rothwell wrote:
Hi all,
(on i386 or x86_64) drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:10148: error: 'bnx2x_fcoe_get_wwn' undeclared here (not in a function) Full randconfig file is attached. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
From: Dmitry Kravkov <hidden>
Date: 2011-08-29 21:35:48
On Mon, 2011-08-29 at 13:28 -0700, Randy Dunlap wrote:
On Mon, 29 Aug 2011 16:19:07 +1000 Stephen Rothwell wrote:quoted
Hi all,(on i386 or x86_64) drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:10148: error: 'bnx2x_fcoe_get_wwn' undeclared here (not in a function) Full randconfig file is attached. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
This should sync #define structures between definition and declaration --- Reported-by: Randy Dunlap <redacted> Signed-off-by: Dmitry Kravkov <redacted> --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
index f290b23..5b1f9b5 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h@@ -522,7 +522,7 @@ void bnx2x_free_mem_bp(struct bnx2x *bp); */ int bnx2x_change_mtu(struct net_device *dev, int new_mtu); -#if defined(BCM_CNIC) && (defined(CONFIG_FCOE) || defined(CONFIG_FCOE_MODULE)) +#if defined(NETDEV_FCOE_WWNN) && defined(BCM_CNIC) /** * bnx2x_fcoe_get_wwn - return the requested WWN value for this port *
--
1.7.2.2
From: Randy Dunlap <hidden>
Date: 2011-08-29 22:56:23
On Tue, 30 Aug 2011 00:35:44 +0300 Dmitry Kravkov wrote:
On Mon, 2011-08-29 at 13:28 -0700, Randy Dunlap wrote:quoted
On Mon, 29 Aug 2011 16:19:07 +1000 Stephen Rothwell wrote:quoted
Hi all,(on i386 or x86_64) drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:10148: error: 'bnx2x_fcoe_get_wwn' undeclared here (not in a function) Full randconfig file is attached. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***This should sync #define structures between definition and declaration --- Reported-by: Randy Dunlap <redacted> Signed-off-by: Dmitry Kravkov <redacted>
Acked-by: Randy Dunlap <redacted> Thanks.
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h index f290b23..5b1f9b5 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h@@ -522,7 +522,7 @@ void bnx2x_free_mem_bp(struct bnx2x *bp); */ int bnx2x_change_mtu(struct net_device *dev, int new_mtu); -#if defined(BCM_CNIC) && (defined(CONFIG_FCOE) || defined(CONFIG_FCOE_MODULE)) +#if defined(NETDEV_FCOE_WWNN) && defined(BCM_CNIC) /** * bnx2x_fcoe_get_wwn - return the requested WWN value for this port *--
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
From: David Miller <davem@davemloft.net>
Date: 2011-08-30 02:59:19
From: Randy Dunlap <redacted> Date: Mon, 29 Aug 2011 15:56:18 -0700
On Tue, 30 Aug 2011 00:35:44 +0300 Dmitry Kravkov wrote:quoted
On Mon, 2011-08-29 at 13:28 -0700, Randy Dunlap wrote:quoted
On Mon, 29 Aug 2011 16:19:07 +1000 Stephen Rothwell wrote:quoted
Hi all,(on i386 or x86_64) drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:10148: error: 'bnx2x_fcoe_get_wwn' undeclared here (not in a function) Full randconfig file is attached. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***This should sync #define structures between definition and declaration --- Reported-by: Randy Dunlap <redacted> Signed-off-by: Dmitry Kravkov <redacted>Acked-by: Randy Dunlap <redacted>
Applied, thanks everyone.