[PATCH] can: ti_hecc: Fix unintialized variable

Subsystems: can network drivers, the rest

STALE5525d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2011-08-26 · open the first message on its own page

[PATCH] can: ti_hecc: Fix unintialized variable

From: Abhilash K V <hidden>
Date: 2011-08-23 13:06:06

In ti_hecc_xmit(), local variable "data" is not initialized before
being used.
This initialization got inadvertently removed in the following patch:

	can: Unify droping of invalid tx skbs and netdev stats

Acked-by: Anant Gole <redacted>
Signed-off-by: Abhilash K V <redacted>
---
 drivers/net/can/ti_hecc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index f7bbde9..0b19a17 100644
--- a/drivers/net/can/ti_hecc.c
+++ b/drivers/net/can/ti_hecc.c
@@ -503,9 +503,9 @@ static netdev_tx_t ti_hecc_xmit(struct sk_buff *skb, struct net_device *ndev)
 	spin_unlock_irqrestore(&priv->mbx_lock, flags);
 
 	/* Prepare mailbox for transmission */
+	data = cf->can_dlc | (get_tx_head_prio(priv) << 8);
 	if (cf->can_id & CAN_RTR_FLAG) /* Remote transmission request */
 		data |= HECC_CANMCF_RTR;
-	data |= get_tx_head_prio(priv) << 8;
 	hecc_write_mbx(priv, mbxno, HECC_CANMCF, data);
 
 	if (cf->can_id & CAN_EFF_FLAG) /* Extended frame format */
-- 
1.6.2.4

Re: [PATCH] can: ti_hecc: Fix unintialized variable

From: David Miller <davem@davemloft.net>
Date: 2011-08-26 16:51:19

From: Abhilash K V <redacted>
Date: Tue, 23 Aug 2011 18:35:48 +0530
In ti_hecc_xmit(), local variable "data" is not initialized before
being used.
This initialization got inadvertently removed in the following patch:

	can: Unify droping of invalid tx skbs and netdev stats

Acked-by: Anant Gole <redacted>
Signed-off-by: Abhilash K V <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help