[Patch] Correct assignment of uid to gid in credentials

This patch corrects an erroneous assignment of uid to gid in credentials
update.

Tim

Signed-off-by: Tim Chen <redacted>

diff --git a/net/core/scm.c b/net/core/scm.c
index 4c1ef02..811b53f 100644
--- a/net/core/scm.c
+++ b/net/core/scm.c

@@ -192,7 +192,7 @@ int __scm_send(struct socket *sock, struct msghdr

*msg, struct scm_cookie *p)
 					goto error;
 
 				cred->uid = cred->euid = p->creds.uid;
-				cred->gid = cred->egid = p->creds.uid;
+				cred->gid = cred->egid = p->creds.gid;
 				put_cred(p->cred);
 				p->cred = cred;
 			}

Le lundi 08 août 2011 à 15:08 -0700, Tim Chen a écrit :

Good catch Tim.

BTW your patch is a bit flawed : one wrapped line and "---" marker
missing.

Could you add in Changelog bug came from commit 257b5358b32f17
(scm: Capture the full credentials of the scm sender) to ease stable
teams work ?
(linux-2.6.36 was the first kernel to include this commit)

On Tue, 2011-08-09 at 04:43 +0200, Eric Dumazet wrote:

Good catch Tim.

BTW your patch is a bit flawed : one wrapped line and "---" marker
missing.

Could you add in Changelog bug came from commit 257b5358b32f17
(scm: Capture the full credentials of the scm sender) to ease stable
teams work ?
(linux-2.6.36 was the first kernel to include this commit)

Updated the log as requested.  Thanks.

Tim

------------

This patch corrects an erroneous update of credential's gid with uid
introduced in commit 257b5358b32f17 since 2.6.36.

Signed-off-by: Tim Chen <redacted>
---

diff --git a/net/core/scm.c b/net/core/scm.c
index 4c1ef02..811b53f 100644
--- a/net/core/scm.c
+++ b/net/core/scm.c

@@ -192,7 +192,7 @@ int __scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie *p)
 					goto error;
 
 				cred->uid = cred->euid = p->creds.uid;
-				cred->gid = cred->egid = p->creds.uid;
+				cred->gid = cred->egid = p->creds.gid;
 				put_cred(p->cred);
 				p->cred = cred;
 			}

This patch corrects an erroneous update of credential's gid with uid
introduced in commit 257b5358b32f17 since 2.6.36.

Please also add a Cc: stable@kernel.org

-Andi

Le mardi 09 août 2011 à 11:06 -0700, Andi Kleen a écrit :

quoted

This patch corrects an erroneous update of credential's gid with uid
introduced in commit 257b5358b32f17 since 2.6.36.

Please also add a Cc: stable@kernel.org

David handles stable submission himself, a priori.

Acked-by: Eric Dumazet <redacted>

On Tue, 9 Aug 2011, Tim Chen wrote:

This patch corrects an erroneous update of credential's gid with uid
introduced in commit 257b5358b32f17 since 2.6.36.

Signed-off-by: Tim Chen <redacted>

Reviewed-by: James Morris <jmorris@namei.org>

-- 
James Morris
[off-list ref]

From: Tim Chen <redacted>
Date: Tue, 09 Aug 2011 09:48:32 -0700

This patch corrects an erroneous update of credential's gid with uid
introduced in commit 257b5358b32f17 since 2.6.36.

Signed-off-by: Tim Chen <redacted>

Applied, thanks.