[net] e1000: Fix driver to be used on PA RISC C8000 workstations

Subsystems: networking drivers, the rest

4 messages, 3 authors, 2011-08-31 · open the first message on its own page

[net] e1000: Fix driver to be used on PA RISC C8000 workstations

From: Jeff Kirsher <hidden>
Date: 2011-08-31 00:19:30

The checksum field in the EEPROM on HPPA is really not a
checksum but a signature (0x16d6).  So allow 0x16d6 as the
matching checksum on HPPA systems.

This issue is present on longterm/stable kernels, I have
verified that this patch is applicable back to at least
2.6.32.y kernels.

CC: Guy Martin <redacted>
CC: Rolf Eike Beer <redacted>
CC: Matt Turner <mattst88@gmail.com>
Reported-by: Mikulas Patocka <redacted>
Signed-off-by: Jeff Kirsher <redacted>
Acked-by: Jesse Brandeburg <redacted>
---
 drivers/net/e1000/e1000_hw.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e1000/e1000_hw.c b/drivers/net/e1000/e1000_hw.c
index 8545c7a..08c1ad5 100644
--- a/drivers/net/e1000/e1000_hw.c
+++ b/drivers/net/e1000/e1000_hw.c
@@ -4026,6 +4026,12 @@ s32 e1000_validate_eeprom_checksum(struct e1000_hw *hw)
 		checksum += eeprom_data;
 	}
 
+#ifdef __hppa__
+	/* This is a signature and not a checksum on HP c8000 */
+	if ((hw->subsystem_vendor_id == 0x103C) && (eeprom_data == 0x16d6))
+		return E1000_SUCCESS;
+
+#endif
 	if (checksum == (u16) EEPROM_SUM)
 		return E1000_SUCCESS;
 	else {
-- 
1.7.6

Re: [net] e1000: Fix driver to be used on PA RISC C8000 workstations

From: David Miller <davem@davemloft.net>
Date: 2011-08-31 00:39:03

From: Jeff Kirsher <redacted>
Date: Tue, 30 Aug 2011 17:19:26 -0700
+#ifdef __hppa__
Please use CONFIG_PARISC

_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable

Re: [net] e1000: Fix driver to be used on PA RISC C8000 workstations

From: Jeff Kirsher <hidden>
Date: 2011-08-31 00:48:37

On Tue, 2011-08-30 at 17:39 -0700, David Miller wrote:
From: Jeff Kirsher <redacted>
Date: Tue, 30 Aug 2011 17:19:26 -0700
quoted
+#ifdef __hppa__
Please use CONFIG_PARISC
Ok, I will put together a v2 of the patch with your suggested change.

Re: [stable] [net] e1000: Fix driver to be used on PA RISC C8000 workstations

From: Greg KH <hidden>
Date: 2011-08-31 15:40:16

On Tue, Aug 30, 2011 at 05:19:26PM -0700, Jeff Kirsher wrote:
The checksum field in the EEPROM on HPPA is really not a
checksum but a signature (0x16d6).  So allow 0x16d6 as the
matching checksum on HPPA systems.

This issue is present on longterm/stable kernels, I have
verified that this patch is applicable back to at least
2.6.32.y kernels.

CC: Guy Martin <redacted>
CC: Rolf Eike Beer <redacted>
CC: Matt Turner <mattst88@gmail.com>
Reported-by: Mikulas Patocka <redacted>
Signed-off-by: Jeff Kirsher <redacted>
Acked-by: Jesse Brandeburg <redacted>
<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help