[patch 3/3 -next] 6LoWPAN: call dev_put() on error in lowpan_newlink()
DORMANTno replies
From: Dan Carpenter <hidden>
Date: 2011-08-30 13:53:31
Also in:
kernel-janitors
Subsystem:
ieee 802.15.4 subsystem, networking [general], the rest · Maintainers:
Alexander Aring, Stefan Schmidt, Miquel Raynal, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
We should release the dev_hold() on error before returning here. Signed-off-by: Dan Carpenter <redacted> --- All three of these patches were compile tested only, but this is the one I'm not very certain of. I've obviously tried to get it right, but please review it carefully.
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index 5dc0489..f0d1536 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c@@ -793,8 +793,11 @@ static int lowpan_newlink(struct net *src_net, struct net_device *dev, mutex_init(&lowpan_dev_info(dev)->dev_list_mtx); entry = kzalloc(sizeof(struct lowpan_dev_record), GFP_KERNEL); - if (!entry) + if (!entry) { + dev_put(real_dev); + lowpan_dev_info(dev)->real_dev = NULL; return -ENOMEM; + } entry->ldev = dev;