[patch net-next-2.6] benet: remove bogus "unlikely" on vlan check

Subsystems: emulex 10gbps nic be2, be3-r, lancer, skyhawk-r driver (be2net), networking drivers, the rest

STALE5525d

2 messages, 2 authors, 2011-08-28 · open the first message on its own page

[patch net-next-2.6] benet: remove bogus "unlikely" on vlan check

From: Jiri Pirko <hidden>
Date: 2011-08-25 12:50:57

Use of unlikely in this place is wrong. Remove it.

Signed-off-by: Jiri Pirko <redacted>
---
 drivers/net/ethernet/emulex/benet/be_main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index fb2eda0..3d55b47 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -1139,7 +1139,7 @@ static void be_rx_compl_process(struct be_adapter *adapter,
 		skb->rxhash = rxcp->rss_hash;
 
 
-	if (unlikely(rxcp->vlanf))
+	if (rxcp->vlanf)
 		__vlan_hwaccel_put_tag(skb, rxcp->vlan_tag);
 
 	netif_receive_skb(skb);
@@ -1196,7 +1196,7 @@ static void be_rx_compl_process_gro(struct be_adapter *adapter,
 	if (adapter->netdev->features & NETIF_F_RXHASH)
 		skb->rxhash = rxcp->rss_hash;
 
-	if (unlikely(rxcp->vlanf))
+	if (rxcp->vlanf)
 		__vlan_hwaccel_put_tag(skb, rxcp->vlan_tag);
 
 	napi_gro_frags(&eq_obj->napi);
-- 
1.7.6

Re: [patch net-next-2.6] benet: remove bogus "unlikely" on vlan check

From: David Miller <davem@davemloft.net>
Date: 2011-08-28 21:14:48

From: Jiri Pirko <redacted>
Date: Thu, 25 Aug 2011 14:50:51 +0200
Use of unlikely in this place is wrong. Remove it.

Signed-off-by: Jiri Pirko <redacted>
I'll apply this, thanks Jiri.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help