[patch net-next-2.6] net: vlan: goto another_round instead of calling __netif_receive_skb

Subsystems: networking [general], the rest

STALE5540d

2 messages, 2 authors, 2011-08-22 · open the first message on its own page

[patch net-next-2.6] net: vlan: goto another_round instead of calling __netif_receive_skb

From: Jiri Pirko <hidden>
Date: 2011-08-22 19:09:30

Now, when vlan tag on untagged in non-accelerated path is stripped from
skb, headers are reset right away. Benefit from that and avoid calling
__netif_receive_skb recursivelly and just use another_round.

Signed-off-by: Jiri Pirko <redacted>
---
 net/core/dev.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index c2442b4..a4306f7 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3236,10 +3236,9 @@ ncls:
 			ret = deliver_skb(skb, pt_prev, orig_dev);
 			pt_prev = NULL;
 		}
-		if (vlan_do_receive(&skb)) {
-			ret = __netif_receive_skb(skb);
-			goto out;
-		} else if (unlikely(!skb))
+		if (vlan_do_receive(&skb))
+			goto another_round;
+		else if (unlikely(!skb))
 			goto out;
 	}
 
-- 
1.7.6

Re: [patch net-next-2.6] net: vlan: goto another_round instead of calling __netif_receive_skb

From: David Miller <davem@davemloft.net>
Date: 2011-08-22 19:44:07

From: Jiri Pirko <redacted>
Date: Mon, 22 Aug 2011 21:08:55 +0200
Now, when vlan tag on untagged in non-accelerated path is stripped from
skb, headers are reset right away. Benefit from that and avoid calling
__netif_receive_skb recursivelly and just use another_round.

Signed-off-by: Jiri Pirko <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help