Re: [PATCH/RFC v3 0/75] enable SKB paged fragment lifetime visibility

5 messages, 4 authors, 2011-08-19 · open the first message on its own page

Re: [PATCH/RFC v3 0/75] enable SKB paged fragment lifetime visibility

From: David Miller <hidden>
Date: 2011-08-19 13:29:58

From: Ian Campbell <redacted>
Date: Fri, 19 Aug 2011 14:26:33 +0100
This is v3 of my series to enable visibility into SKB paged fragment's
Please tone down the patch count :-/  I'm not going to review anything more
than ~20 or so patches at a time from any one person.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v3 0/75] enable SKB paged fragment lifetime visibility

From: David Miller <davem@davemloft.net>
Date: 2011-08-19 13:34:12

From: David Miller <davem@davemloft.net>
Date: Fri, 19 Aug 2011 06:29:58 -0700 (PDT)
From: Ian Campbell <redacted>
Date: Fri, 19 Aug 2011 14:26:33 +0100
quoted
This is v3 of my series to enable visibility into SKB paged fragment's
Please tone down the patch count :-/  I'm not going to review anything more
than ~20 or so patches at a time from any one person.
Also none of your patches will even apply to net-next GIT since nearly
all the ethernet drivers have been moved under drivers/net/ethernet

Re: [PATCH/RFC v3 0/75] enable SKB paged fragment lifetime visibility

From: Ian Campbell <hidden>
Date: 2011-08-19 13:45:22

On Fri, 2011-08-19 at 14:34 +0100, David Miller wrote:
From: David Miller <davem@davemloft.net>
Date: Fri, 19 Aug 2011 06:29:58 -0700 (PDT)
quoted
From: Ian Campbell <redacted>
Date: Fri, 19 Aug 2011 14:26:33 +0100
quoted
This is v3 of my series to enable visibility into SKB paged fragment's
Please tone down the patch count :-/  I'm not going to review anything more
than ~20 or so patches at a time from any one person.
Unfortunately I didn't see any middle ground between one massive patch
munging drivers with lots of different maintainers and one patch per
maintainer (which is loads).

I'll resend in batches of ~20. After the first patch all the "convert to
SKB paged frag API" patches are independent.

Would you be willing to just review patches 1-20 of this series? In
which case I could avoid spamming the list with those again now.
Also none of your patches will even apply to net-next GIT since nearly
all the ethernet drivers have been moved under drivers/net/ethernet
Yes, I noted that in my intro mail and will rebase for v4. Since it's
mostly just been code motion I think review in the old place will still
be largely valid.

Ian.

Re: [PATCH/RFC v3 0/75] enable SKB paged fragment lifetime visibility

From: David Miller <davem@davemloft.net>
Date: 2011-08-19 14:04:54

From: David Miller <davem@davemloft.net>
Date: Fri, 19 Aug 2011 06:34:10 -0700 (PDT)
From: David Miller <davem@davemloft.net>
Date: Fri, 19 Aug 2011 06:29:58 -0700 (PDT)
quoted
From: Ian Campbell <redacted>
Date: Fri, 19 Aug 2011 14:26:33 +0100
quoted
This is v3 of my series to enable visibility into SKB paged fragment's
Please tone down the patch count :-/  I'm not going to review anything more
than ~20 or so patches at a time from any one person.
Also none of your patches will even apply to net-next GIT since nearly
all the ethernet drivers have been moved under drivers/net/ethernet
Ian, please acknowledge my grievances here.  I see you replying to other
people, but not to me and I'm the one who has to process all of this
stuff eventually.

If you want this series to be taken seriously:

1) Make your patches against net-next GIT, none of your driver patches will
   apply because they have all been moved around to different locations
   under drivers/net

2) Submit this in a _SANE_ way.  This means, get the first patch that adds
   the new interfaces approved and merged.  Then slowly and carefuly submit
   small, reasonably sized, sets of patches that convert the drivers over.

Otherwise there is no way I'm even looking at this stuff, let alone actually
apply it.

Realize that every time you patch bomb rediculiously like this I have
to click and classify every single patch in your bomb at
http://patchwork.ozlabs.org/project/netdev/list/

Re: [PATCH/RFC v3 0/75] enable SKB paged fragment lifetime visibility

From: Ian Campbell <hidden>
Date: 2011-08-19 14:30:17

On Fri, 2011-08-19 at 07:04 -0700, David Miller wrote:
From: David Miller <davem@davemloft.net>
Date: Fri, 19 Aug 2011 06:34:10 -0700 (PDT)
quoted
From: David Miller <davem@davemloft.net>
Date: Fri, 19 Aug 2011 06:29:58 -0700 (PDT)
quoted
From: Ian Campbell <redacted>
Date: Fri, 19 Aug 2011 14:26:33 +0100
quoted
This is v3 of my series to enable visibility into SKB paged fragment's
Please tone down the patch count :-/  I'm not going to review anything more
than ~20 or so patches at a time from any one person.
Also none of your patches will even apply to net-next GIT since nearly
all the ethernet drivers have been moved under drivers/net/ethernet
Ian, please acknowledge my grievances here.  I see you replying to other
people, but not to me and I'm the one who has to process all of this
stuff eventually.
Sorry, I thought I had replied to you first, did it go missing?
If you want this series to be taken seriously:

1) Make your patches against net-next GIT, none of your driver patches will
   apply because they have all been moved around to different locations
   under drivers/net
2) Submit this in a _SANE_ way.  This means, get the first patch that adds
   the new interfaces approved and merged.  Then slowly and carefuly submit
   small, reasonably sized, sets of patches that convert the drivers over.
That all makes sense, I'll do it that way.
Otherwise there is no way I'm even looking at this stuff, let alone actually
apply it.
Realize that every time you patch bomb rediculiously like this I have
to click and classify every single patch in your bomb at
http://patchwork.ozlabs.org/project/netdev/list/
Ah, right, I hadn't considered the patchwork thing, I'm very sorry about
that!

Ian.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help