[patch net-2.6] via-velocity: remove non-tagged packet filtering

Subsystems: networking drivers, the rest

STALE5534d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2011-08-18 · open the first message on its own page

[patch net-2.6] via-velocity: remove non-tagged packet filtering

From: Jiri Pirko <hidden>
Date: 2011-08-16 08:33:46

It's undesired to filter untagged packets at any time. So simply remove this.

Reported-by: Stephan Bärwolf <redacted>
Tested-by: Stephan Bärwolf <redacted>
Signed-off-by: Jiri Pirko <redacted>
---
 drivers/net/via-velocity.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index deb1eca..7c5336c 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -515,10 +515,6 @@ static void velocity_init_cam_filter(struct velocity_info *vptr)
 	mac_set_cam_mask(regs, vptr->mCAMmask);
 
 	/* Enable VCAMs */
-
-	if (test_bit(0, vptr->active_vlans))
-		WORD_REG_BITS_ON(MCFG_RTGOPT, &regs->MCFG);
-
 	for_each_set_bit(vid, vptr->active_vlans, VLAN_N_VID) {
 		mac_set_vlan_cam(regs, i, (u8 *) &vid);
 		vptr->vCAMmask[i / 8] |= 0x1 << (i % 8);
-- 
1.7.6

Re: [patch net-2.6] via-velocity: remove non-tagged packet filtering

From: David Miller <davem@davemloft.net>
Date: 2011-08-18 03:14:14

From: Jiri Pirko <redacted>
Date: Tue, 16 Aug 2011 10:33:34 +0200
It's undesired to filter untagged packets at any time. So simply remove this.

Reported-by: Stephan Bärwolf <redacted>
Tested-by: Stephan Bärwolf <redacted>
Signed-off-by: Jiri Pirko <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help