[PATCH] net_sched: fix port mirror/redirect stats reporting

Subsystems: networking [general], tc subsystem, the rest

STALE5535d

2 messages, 2 authors, 2011-08-18 · open the first message on its own page

[PATCH] net_sched: fix port mirror/redirect stats reporting

From: jamal <hidden>
Date: 2011-08-15 15:25:50

commit 6a51508a01671114c236602d071d4bff53422c60
Author: Jamal Hadi Salim [off-list ref]
Date:   Mon Aug 15 11:17:06 2011 -0400

    [PATCH] net_sched: fix port mirror/redirect stats reporting
    
    When a redirected or mirrored packet is dropped by the target
    device we need to record statistics.
    
    Signed-off-by: Jamal Hadi Salim [off-list ref]
diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
index 961386e..d5ef6ec 100644
--- a/net/sched/act_mirred.c
+++ b/net/sched/act_mirred.c
@@ -196,8 +196,7 @@ static int tcf_mirred(struct sk_buff *skb, struct tc_action *a,
 
 	skb2->skb_iif = skb->dev->ifindex;
 	skb2->dev = dev;
-	dev_queue_xmit(skb2);
-	err = 0;
+	err = dev_queue_xmit(skb2);
 
 out:
 	if (err) {

Re: [PATCH] net_sched: fix port mirror/redirect stats reporting

From: David Miller <davem@davemloft.net>
Date: 2011-08-18 03:10:58

From: jamal <redacted>
Date: Mon, 15 Aug 2011 11:25:40 -0400
commit 6a51508a01671114c236602d071d4bff53422c60
Author: Jamal Hadi Salim [off-list ref]
Date:   Mon Aug 15 11:17:06 2011 -0400

    [PATCH] net_sched: fix port mirror/redirect stats reporting
    
    When a redirected or mirrored packet is dropped by the target
    device we need to record statistics.
    
    Signed-off-by: Jamal Hadi Salim [off-list ref]
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help