Re: [PATCH ] cdc_ncm: fixes for big-endian architecture / MIPS

Am Dienstag, 2. August 2011, 18:20:26 schrieb Alexey Orishko:

Changes:
- removed redandunt conversion for usb control requests
- added missing conversion for nth16.wNdpIndex
Thanks to Giuseppe Scrivano for providing fixes

What? How can a conversion of endianness be redundant?
Either this version or the old version must be buggy. What is
happening here?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Tue, 2 Aug 2011, Oliver Neukum wrote:

Am Dienstag, 2. August 2011, 18:20:26 schrieb Alexey Orishko:

quoted

Changes:
- removed redandunt conversion for usb control requests
- added missing conversion for nth16.wNdpIndex
Thanks to Giuseppe Scrivano for providing fixes

What? How can a conversion of endianness be redundant?

When it's done twice.  :-)

Either this version or the old version must be buggy. What is
happening here?

The old version is buggy.  Read the code and you'll see.

Alan Stern