Re: [PATCH v2 0/3] Add device tree probe support for imx fec driver

From: Shawn Guo <redacted>
Date: Tue, 5 Jul 2011 23:13:56 +0800

The first two patches are a little off topic.  Patch #1 adds a helper
function of_get_phy_mode into of_net, and #2 converts ibm_newemac net
driver to use this helper function.  Patch #3 is the actual one adding
tree probe support for imx fec driver, with of_get_phy_mode being used.

Changes since v1:
 * Address review comments given by Grant
 * Add patch #1 and #2

Shawn Guo (3):
      dt/net: add helper function of_get_phy_mode
      net: ibm_newemac: convert it to use of_get_phy_mode
      net/fec: add device tree probe support

All applied to net-next-2.6, thanks.

From: David Miller <davem@davemloft.net>
Date: Tue, 05 Jul 2011 19:48:54 -0700 (PDT)

All applied to net-next-2.6, thanks.

Come on guys:

drivers/of/of_net.c: In function 'of_get_phy_mode':
drivers/of/of_net.c:45: error: implicit declaration of function 'of_property_read_string'

This is completely rediculious.

Don't tell me that it's appropriate to merge something into
my net tree when it uses interfaces that don't even exist
in Linus's tree.

On Tue, Jul 05, 2011 at 10:30:45PM -0700, David Miller wrote:

From: David Miller <davem@davemloft.net>
Date: Tue, 05 Jul 2011 19:48:54 -0700 (PDT)

quoted

All applied to net-next-2.6, thanks.

Come on guys:

drivers/of/of_net.c: In function 'of_get_phy_mode':
drivers/of/of_net.c:45: error: implicit declaration of function 'of_property_read_string'

This is completely rediculious.

Don't tell me that it's appropriate to merge something into
my net tree when it uses interfaces that don't even exist
in Linus's tree.

Sorry about that, I missed the reference to that function which is
currently in my devicetree/next branch.  I can either take the series
via devicetree/next, or I can provide you with a topic branch
containing the needed commit that you can merge.  Whichever you prefer.

g.

From: Grant Likely <redacted>
Date: Wed, 6 Jul 2011 00:19:01 -0600

Sorry about that, I missed the reference to that function which is
currently in my devicetree/next branch.  I can either take the series
via devicetree/next, or I can provide you with a topic branch
containing the needed commit that you can merge.  Whichever you prefer.

Please just take the series, thanks.

On Tue, Jul 05, 2011 at 11:22:52PM -0700, David Miller wrote:

From: Grant Likely <redacted>
Date: Wed, 6 Jul 2011 00:19:01 -0600

quoted

Sorry about that, I missed the reference to that function which is
currently in my devicetree/next branch.  I can either take the series
via devicetree/next, or I can provide you with a topic branch
containing the needed commit that you can merge.  Whichever you prefer.

Please just take the series, thanks.

I think the easier way is that I repost the series after
devicetree/next and i.mx tree get merged in the coming window, and
let them go through i.mx tree.

David, I assume I can add your acks to all 3 patches, otherwise
please let me know.

-- 
Regards,
Shawn

From: Shawn Guo <redacted>
Date: Fri, 22 Jul 2011 10:08:19 +0800

David, I assume I can add your acks to all 3 patches, otherwise
please let me know.

Yes, you can.