[PATCH 1/1] IPv4: Send gratuitous ARP for secondary IP addresses also

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE5533d

2 messages, 2 authors, 2011-07-25 · open the first message on its own page

[PATCH 1/1] IPv4: Send gratuitous ARP for secondary IP addresses also

From: Zoltan, Kiss <hidden>
Date: 2011-07-25 00:09:43

From: Zoltan Kiss <redacted>

If a device event generates gratuitous ARP messages, only primary
address is used for sending. This patch iterates through the whole
list. Tested with 2 IP addresses configuration on bonding interface.

Signed-off-by: Zoltan Kiss <redacted>
---
 net/ipv4/devinet.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 37b3c18..bc19bd0 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1134,15 +1134,15 @@ static void inetdev_send_gratuitous_arp(struct net_device *dev,
 					struct in_device *in_dev)
 
 {
-	struct in_ifaddr *ifa = in_dev->ifa_list;
-
-	if (!ifa)
-		return;
+	struct in_ifaddr *ifa;
 
-	arp_send(ARPOP_REQUEST, ETH_P_ARP,
-		 ifa->ifa_local, dev,
-		 ifa->ifa_local, NULL,
-		 dev->dev_addr, NULL);
+	for (ifa = in_dev->ifa_list; ifa;
+	     ifa = ifa->ifa_next) {
+		arp_send(ARPOP_REQUEST, ETH_P_ARP,
+			 ifa->ifa_local, dev,
+			 ifa->ifa_local, NULL,
+			 dev->dev_addr, NULL);
+	}
 }
 
 /* Called only under RTNL semaphore */
-- 
1.7.4.1

Re: [PATCH 1/1] IPv4: Send gratuitous ARP for secondary IP addresses also

From: David Miller <davem@davemloft.net>
Date: 2011-07-25 23:20:44

From: "Zoltan, Kiss" <redacted>
Date: Mon, 25 Jul 2011 01:09:30 +0200
From: Zoltan Kiss <redacted>

If a device event generates gratuitous ARP messages, only primary
address is used for sending. This patch iterates through the whole
list. Tested with 2 IP addresses configuration on bonding interface.

Signed-off-by: Zoltan Kiss <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help