[PATCH] xfrm: Fix key lengths for rfc3686(ctr(aes))

Subsystems: networking [general], networking [ipsec], the rest

STALE5488d

3 messages, 3 authors, 2011-07-29 · open the first message on its own page

[PATCH] xfrm: Fix key lengths for rfc3686(ctr(aes))

From: Tushar Gohad <hidden>
Date: 2011-07-28 20:46:26

Fix the min and max bit lengths for AES-CTR (RFC3686) keys.
The number of bits in key spec is the key length (128/256)
plus 32 bits of nonce.

This change takes care of the "Invalid key length" errors
reported by setkey when specifying 288 bit keys for aes-ctr.

Signed-off-by: Tushar Gohad <redacted>
---
  net/xfrm/xfrm_algo.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c
index 58064d9..791ab2e 100644
--- a/net/xfrm/xfrm_algo.c
+++ b/net/xfrm/xfrm_algo.c
@@ -462,8 +462,8 @@ static struct xfrm_algo_desc ealg_list[] = {
  	.desc = {
  		.sadb_alg_id = SADB_X_EALG_AESCTR,
  		.sadb_alg_ivlen	= 8,
-		.sadb_alg_minbits = 128,
-		.sadb_alg_maxbits = 256
+		.sadb_alg_minbits = 160,
+		.sadb_alg_maxbits = 288
  	}
  },
  };
-- 
1.6.3.3.202.g91879

Re: [PATCH] xfrm: Fix key lengths for rfc3686(ctr(aes))

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2011-07-29 00:05:51

On Thu, Jul 28, 2011 at 01:36:20PM -0700, Tushar Gohad wrote:
Fix the min and max bit lengths for AES-CTR (RFC3686) keys.
The number of bits in key spec is the key length (128/256)
plus 32 bits of nonce.

This change takes care of the "Invalid key length" errors
reported by setkey when specifying 288 bit keys for aes-ctr.

Signed-off-by: Tushar Gohad <redacted>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] xfrm: Fix key lengths for rfc3686(ctr(aes))

From: David Miller <davem@davemloft.net>
Date: 2011-07-29 01:27:58

From: Tushar Gohad <redacted>
Date: Thu, 28 Jul 2011 13:36:20 -0700 (MST)
Fix the min and max bit lengths for AES-CTR (RFC3686) keys.
The number of bits in key spec is the key length (128/256)
plus 32 bits of nonce.

This change takes care of the "Invalid key length" errors
reported by setkey when specifying 288 bit keys for aes-ctr.

Signed-off-by: Tushar Gohad <redacted>
APplied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help