RE: gianfar vlan

Hi Jirka!

The rx queue filer table also needs the RCTRL_PRSDEP_INIT to be set. So I would suggest to add FILREN to RCTRL_REQ_PARSER.

Further I guess the parser should only be enabled if it is necessary (because of VLAN, IP, TCP or FILREN acceleration modes).

What about putting the

if (tempval & RCTRL_REQ_PARSER)
	tempval |= RCTRL_PRSDEP_INIT;
else
	tempval &= ~RCTRL_PRSDEP_INIT;

in a dedicated routine and call it every time one of the four features is altered?

Greetings
Sebastian

Hi Sandeep.

I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
enabling/disabling to gfar_set_features() -> startup_gfar() ->
gfar_init_mac(). I'm not sure how to handle following lines in
gfar_vlan_rx_register():

/* If parse is no longer required, then disable parser */
if (tempval & RCTRL_REQ_PARSER)
tempval |= RCTRL_PRSDEP_INIT;
else
tempval &= ~RCTRL_PRSDEP_INIT;

Should this be done only on disabling vlan accel (both rx an tx)?
Or can I just do that always in startup_gfar() ?

Thanks.

Jirka

Fri, Jul 15, 2011 at 09:59:03AM CEST, sebastian.belden@googlemail.com wrote:

Hi Jirka!

The rx queue filer table also needs the RCTRL_PRSDEP_INIT to be set. So I would suggest to add FILREN to RCTRL_REQ_PARSER.

Further I guess the parser should only be enabled if it is necessary (because of VLAN, IP, TCP or FILREN acceleration modes).

What about putting the

if (tempval & RCTRL_REQ_PARSER)
tempval |= RCTRL_PRSDEP_INIT;
else
tempval &= ~RCTRL_PRSDEP_INIT;

in a dedicated routine and call it every time one of the four features is altered?

Ok why not. Would you please cook up the patch and post it? Thanks.

Jirka

Greetings
Sebastian

quoted

Hi Sandeep.

I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
enabling/disabling to gfar_set_features() -> startup_gfar() ->
gfar_init_mac(). I'm not sure how to handle following lines in
gfar_vlan_rx_register():

/* If parse is no longer required, then disable parser */
if (tempval & RCTRL_REQ_PARSER)
tempval |= RCTRL_PRSDEP_INIT;
else
tempval &= ~RCTRL_PRSDEP_INIT;

Should this be done only on disabling vlan accel (both rx an tx)?
Or can I just do that always in startup_gfar() ?

Thanks.

Jirka