[PATCH net-next 0/2] bonding: delete two unused variables

STALE5533d

5 messages, 2 authors, 2011-06-09 · open the first message on its own page

[PATCH net-next 0/2] bonding: delete two unused variables

From: Weiping Pan <hidden>
Date: 2011-06-09 02:51:20

Delete two unused variables in bonding.

Weiping Pan (2):
  bonding: delete unused ad_timer
  bonding: delete unused arp_mon_pt

 drivers/net/bonding/bond_3ad.h |    1 -
 drivers/net/bonding/bonding.h  |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

-- 
1.7.4.4

[PATCH net-next 1/2] bonding: delete unused ad_timer

From: Weiping Pan <hidden>
Date: 2011-06-09 02:51:33

Now we use agg_select_timer and ad_work.

Signed-off-by: Weiping Pan <redacted>
---
 drivers/net/bonding/bond_3ad.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bonding/bond_3ad.h b/drivers/net/bonding/bond_3ad.h
index 0ee3f16..fb67185 100644
--- a/drivers/net/bonding/bond_3ad.h
+++ b/drivers/net/bonding/bond_3ad.h
@@ -257,7 +257,6 @@ struct ad_bond_info {
 	int lacp_fast;		/* whether fast periodic tx should be
 				 * requested
 				 */
-	struct timer_list ad_timer;
 };
 
 struct ad_slave_info {
-- 
1.7.4.4

[PATCH net-next 2/2] bonding: delete unused arp_mon_pt

From: Weiping Pan <hidden>
Date: 2011-06-09 02:51:43

Now all received packets are handled by bond_handle_frame,
arp_mon_pt isn't used any more.

Signed-off-by: Weiping Pan <redacted>
---
 drivers/net/bonding/bonding.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index ea1d005..382903f 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -240,7 +240,6 @@ struct bonding {
 	struct   bond_params params;
 	struct   list_head vlan_list;
 	struct   vlan_group *vlgrp;
-	struct   packet_type arp_mon_pt;
 	struct   workqueue_struct *wq;
 	struct   delayed_work mii_work;
 	struct   delayed_work arp_work;
-- 
1.7.4.4

Re: [PATCH net-next 0/2] bonding: delete two unused variables

From: Américo Wang <hidden>
Date: 2011-06-09 03:19:11

On Thu, Jun 9, 2011 at 10:51 AM, Weiping Pan [off-list ref] wrote:
Delete two unused variables in bonding.

Weiping Pan (2):
 bonding: delete unused ad_timer
 bonding: delete unused arp_mon_pt
Both look good to me,

Reviewed-by: WANG Cong <redacted>

Thanks.

Re: [PATCH net-next 0/2] bonding: delete two unused variables

From: WeipingPan <hidden>
Date: 2011-06-09 07:23:17

On 06/09/2011 11:19 AM, Américo Wang wrote:
On Thu, Jun 9, 2011 at 10:51 AM, Weiping Pan[off-list ref]  wrote:
quoted
Delete two unused variables in bonding.

Weiping Pan (2):
  bonding: delete unused ad_timer
  bonding: delete unused arp_mon_pt
Both look good to me,

Reviewed-by: WANG Cong<redacted>

Thanks.
thanks,
But I move these two patches into another patchset,
the title is "[PATCH v4 net-next 0/5] bonding:use latest lacp_rate and 
ad_select and delete unused ad_timer and arp_mon_pt"

Hope it will be convenient to be reviewed and merged, so forget these 
two patches.

thanks
Weiping Pan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help