[PATCH] qlge: remove unecessary if statement

Subsystems: networking drivers, the rest

STALE5536d

2 messages, 2 authors, 2011-06-07 · open the first message on its own page

[PATCH] qlge: remove unecessary if statement

From: Greg Dietsche <hidden>
Date: 2011-06-06 00:44:20

the code always returns 'status' regardless, so if(status) check is unecessary.

Signed-off-by: Greg Dietsche <redacted>
---
 drivers/net/qlge/qlge_ethtool.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qlge/qlge_ethtool.c b/drivers/net/qlge/qlge_ethtool.c
index 19b00fa..9b67bfe 100644
--- a/drivers/net/qlge/qlge_ethtool.c
+++ b/drivers/net/qlge/qlge_ethtool.c
@@ -650,8 +650,6 @@ static int ql_set_pauseparam(struct net_device *netdev,
 		return -EINVAL;
 
 	status = ql_mb_set_port_cfg(qdev);
-	if (status)
-		return status;
 	return status;
 }
 
-- 
1.7.2.5

Re: [PATCH] qlge: remove unecessary if statement

From: David Miller <davem@davemloft.net>
Date: 2011-06-07 05:53:27

From: Greg Dietsche <redacted>
Date: Sun,  5 Jun 2011 19:44:13 -0500
the code always returns 'status' regardless, so if(status) check is unecessary.

Signed-off-by: Greg Dietsche <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help