[PATCH net-next-2.6 3/3] be2net: fix initialization of vlan_prio_bmap

Subsystems: networking drivers, the rest

STALE5513d

2 messages, 2 authors, 2011-06-27 · open the first message on its own page

[PATCH net-next-2.6 3/3] be2net: fix initialization of vlan_prio_bmap

From: Sathya Perla <hidden>
Date: 2011-06-27 06:41:34

Initialization of this field to "all priorities" must be done before MCC queue
creation. As soon as the MCC queue is created, an event modifying this value
may be received.

Signed-off-by: Sathya Perla <redacted>
---
 drivers/net/benet/be_main.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
index 2373d39..ae281de 100644
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -2554,6 +2554,9 @@ static int be_setup(struct be_adapter *adapter)
 	if (status != 0)
 		goto tx_qs_destroy;
 
+	/* Allow all priorities by default. A GRP5 evt may modify this */
+	adapter->vlan_prio_bmap = 0xff;
+
 	status = be_mcc_queues_create(adapter);
 	if (status != 0)
 		goto rx_qs_destroy;
@@ -3419,10 +3422,6 @@ static int __devinit be_probe(struct pci_dev *pdev,
 	}
 
 	dev_info(&pdev->dev, "%s port %d\n", nic_name(pdev), adapter->port_num);
-	/* By default all priorities are enabled.
-	 * Needed in case of no GRP5 evt support
-	 */
-	adapter->vlan_prio_bmap = 0xff;
 
 	schedule_delayed_work(&adapter->work, msecs_to_jiffies(100));
 	return 0;
-- 
1.7.4

Re: [PATCH net-next-2.6 3/3] be2net: fix initialization of vlan_prio_bmap

From: David Miller <davem@davemloft.net>
Date: 2011-06-27 07:07:57

From: Sathya Perla <redacted>
Date: Mon, 27 Jun 2011 12:11:53 +0530
Initialization of this field to "all priorities" must be done before MCC queue
creation. As soon as the MCC queue is created, an event modifying this value
may be received.

Signed-off-by: Sathya Perla <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help