[PATCH net-2.6] caif: Bugfix - XOFF removed channel from caif-mux

Subsystems: networking [general], the rest

STALE5530d

2 messages, 2 authors, 2011-06-17 · open the first message on its own page

[PATCH net-2.6] caif: Bugfix - XOFF removed channel from caif-mux

From: Sjur Brændeland <hidden>
Date: 2011-06-15 23:38:32

XOFF was mixed up with DOWN indication, causing causing CAIF channel to be
removed from mux and all incoming traffic to be lost after receiving flow-off.
Fix this by replacing FLOW_OFF with DOWN notification.

Signed-off-by: Sjur Brændeland <redacted>
---
Hi Dave,
Please consider this bugfix for Linux 3.0.
It's a one-liner fixing a silly copy-paste mistake.

Thanks,
Sjur 

 net/caif/cfmuxl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/caif/cfmuxl.c b/net/caif/cfmuxl.c
index 3a66b8c..c23979e 100644
--- a/net/caif/cfmuxl.c
+++ b/net/caif/cfmuxl.c
@@ -255,7 +255,7 @@ static void cfmuxl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl,
 
 		if (cfsrvl_phyid_match(layer, phyid) && layer->ctrlcmd) {
 
-			if ((ctrl == _CAIF_CTRLCMD_PHYIF_FLOW_OFF_IND ||
+			if ((ctrl == _CAIF_CTRLCMD_PHYIF_DOWN_IND ||
 				ctrl == CAIF_CTRLCMD_REMOTE_SHUTDOWN_IND) &&
 					layer->id != 0) {
 
-- 
1.7.0.4

Re: [PATCH net-2.6] caif: Bugfix - XOFF removed channel from caif-mux

From: David Miller <davem@davemloft.net>
Date: 2011-06-17 03:59:30

From: Sjur Brændeland <redacted>
Date: Thu, 16 Jun 2011 00:38:25 +0200
XOFF was mixed up with DOWN indication, causing causing CAIF channel to be
removed from mux and all incoming traffic to be lost after receiving flow-off.
Fix this by replacing FLOW_OFF with DOWN notification.

Signed-off-by: Sjur Brændeland <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help