6 messages, 2 authors, 2011-06-14 · open the first message on its own page
From: David Woodhouse <dwmw2@infradead.org>
Date: 2011-06-14 09:48:08
On Tue, 2011-06-14 at 12:41 +0300, Vlad Zolotarov wrote:
bnx2x/bnx2x-e1-7.0.20.0.fw.ihex |10075 +++++++++++++++++++++ bnx2x/bnx2x-e1h-7.0.20.0.fw.ihex |10538 ++++++++++++++++++++++ bnx2x/bnx2x-e2-7.0.20.0.fw.ihex |18190 ++++++++++++++++++++++++++++++++++++++
You haven't tested this, have you? Add the binary file, not an ihex version. -- dwmw2
From: Vlad Zolotarov <hidden>
Date: 2011-06-14 09:58:26
On Tuesday 14 June 2011 12:48:06 David Woodhouse wrote:
On Tue, 2011-06-14 at 12:41 +0300, Vlad Zolotarov wrote:quoted
bnx2x/bnx2x-e1-7.0.20.0.fw.ihex |10075 +++++++++++++++++++++ bnx2x/bnx2x-e1h-7.0.20.0.fw.ihex |10538 ++++++++++++++++++++++ bnx2x/bnx2x-e2-7.0.20.0.fw.ihex |18190 ++++++++++++++++++++++++++++++++++++++You haven't tested this, have you?
What do u mean? I do have put the ihex files under the net-next kernel tree at the regular location plus I updated the the kernel's firmware/WHENCE and firmware/Makefile files and of course I ran a functionality tests for the driver after all patches and with the new firmware. If u meant the different sort of testing, pls., clarify.
Add the binary file, not an ihex version.
I'll resend the binary files. thanks, vlad
From: David Woodhouse <dwmw2@infradead.org>
Date: 2011-06-14 10:04:20
On Tue, 2011-06-14 at 12:57 +0300, Vlad Zolotarov wrote:
What do u mean? I do have put the ihex files under the net-next kernel tree at the regular location plus I updated the the kernel's firmware/WHENCE and firmware/Makefile files and of course I ran a functionality tests for the driver after all patches and with the new firmware.
Ah, there lies your problem. Never put new firmware into the kernel source tree. It doesn't belong there. In the linux-firmware tree we store the *binary* files, which go directly into /lib/firmware as-is. -- dwmw2
From: Vlad Zolotarov <hidden>
Date: 2011-06-14 10:11:00
On Tuesday 14 June 2011 13:04:18 David Woodhouse wrote:
On Tue, 2011-06-14 at 12:57 +0300, Vlad Zolotarov wrote:quoted
What do u mean? I do have put the ihex files under the net-next kernel tree at the regular location plus I updated the the kernel's firmware/WHENCE and firmware/Makefile files and of course I ran a functionality tests for the driver after all patches and with the new firmware.Ah, there lies your problem. Never put new firmware into the kernel source tree. It doesn't belong there. In the linux-firmware tree we store the *binary* files, which go directly into /lib/firmware as-is.
Aha... Correct me if I got u wrong: to test it I need to manually copy the new .fw files into the /lib/firmware directory, install the clean net-next kernel with the driver that supports this new FW and it should work. Is it what u meant? thanks, vlad
From: David Woodhouse <dwmw2@infradead.org>
Date: 2011-06-14 10:16:46
On Tue, 2011-06-14 at 13:10 +0300, Vlad Zolotarov wrote:
Aha... Correct me if I got u wrong: to test it I need to manually copy the new .fw files into the /lib/firmware directory, install the clean net-next kernel with the driver that supports this new FW and it should work. Is it what u meant?
Right. Imagine that you have checked out the linux-firmware.git repository directly into /lib/firmware, and nothing else has been written there. -- dwmw2
From: Vlad Zolotarov <hidden>
Date: 2011-06-14 10:54:26
On Tuesday 14 June 2011 13:16:43 David Woodhouse wrote:
On Tue, 2011-06-14 at 13:10 +0300, Vlad Zolotarov wrote:quoted
Aha... Correct me if I got u wrong: to test it I need to manually copy the new .fw files into the /lib/firmware directory, install the clean net-next kernel with the driver that supports this new FW and it should work. Is it what u meant?Right. Imagine that you have checked out the linux-firmware.git repository directly into /lib/firmware, and nothing else has been written there.
Got it. I checked it now and surprizingly it worked... ;) thanks, man. I'm resending u *binaries* ...