[PATCH] qlcnic: Avoid double free of skb in tx path

Subsystems: networking drivers, the rest

STALE5535d

2 messages, 2 authors, 2011-06-05 · open the first message on its own page

[PATCH] qlcnic: Avoid double free of skb in tx path

From: Anirban Chakraborty <hidden>
Date: 2011-06-03 15:59:28

From: Sucheta Chakraborty <redacted>

buffer->skb should be marked NULL to avoid double free of the skb.

Signed-off-by: Sucheta Chakraborty <redacted>
Signed-off-by: Anirban Chakraborty <redacted>
---
 drivers/net/qlcnic/qlcnic_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
index 3ab7d2c..0f6af5c 100644
--- a/drivers/net/qlcnic/qlcnic_main.c
+++ b/drivers/net/qlcnic/qlcnic_main.c
@@ -2159,6 +2159,7 @@ qlcnic_unmap_buffers(struct pci_dev *pdev, struct sk_buff *skb,
 
 	nf = &pbuf->frag_array[0];
 	pci_unmap_single(pdev, nf->dma, skb_headlen(skb), PCI_DMA_TODEVICE);
+	pbuf->skb = NULL;
 }
 
 static inline void
-- 
1.7.4.1

Re: [PATCH] qlcnic: Avoid double free of skb in tx path

From: David Miller <davem@davemloft.net>
Date: 2011-06-05 21:18:47

From: Anirban Chakraborty <redacted>
Date: Fri,  3 Jun 2011 08:52:18 -0700
From: Sucheta Chakraborty <redacted>

buffer->skb should be marked NULL to avoid double free of the skb.

Signed-off-by: Sucheta Chakraborty <redacted>
Signed-off-by: Anirban Chakraborty <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help