[PATCHv2 NEXT 1/1] netxen: suppress false lro warning messages

Subsystems: networking drivers, the rest

2 messages, 2 authors, 2011-06-03 · open the first message on its own page

[PATCHv2 NEXT 1/1] netxen: suppress false lro warning messages

From: <hidden>
Date: 2011-06-02 12:31:22

From: Sucheta Chakraborty <redacted>

When interface is down, driver prints false warning messages
during lro configuration through ethtool.

Signed-off-by: Sucheta Chakraborty <redacted>
Signed-off-by: Amit Kumar Salecha <redacted>
---
 drivers/net/netxen/netxen_nic_hw.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/netxen/netxen_nic_hw.c b/drivers/net/netxen/netxen_nic_hw.c
index 5cef718..3f89e57 100644
--- a/drivers/net/netxen/netxen_nic_hw.c
+++ b/drivers/net/netxen/netxen_nic_hw.c
@@ -809,6 +809,9 @@ int netxen_config_hw_lro(struct netxen_adapter *adapter, int enable)
 	u64 word;
 	int rv = 0;
 
+	if (!test_bit(__NX_FW_ATTACHED, &adapter->state))
+		return 0;
+
 	memset(&req, 0, sizeof(nx_nic_req_t));
 
 	req.qhdr = cpu_to_le64(NX_HOST_REQUEST << 23);
@@ -959,6 +962,9 @@ int netxen_send_lro_cleanup(struct netxen_adapter *adapter)
 	u64 word;
 	int rv;
 
+	if (!test_bit(__NX_FW_ATTACHED, &adapter->state))
+		return 0;
+
 	memset(&req, 0, sizeof(nx_nic_req_t));
 	req.qhdr = cpu_to_le64(NX_HOST_REQUEST << 23);
 
-- 
1.7.3.3

Re: [PATCHv2 NEXT 1/1] netxen: suppress false lro warning messages

From: David Miller <davem@davemloft.net>
Date: 2011-06-03 07:03:46

From: amit.salecha@qlogic.com
Date: Thu,  2 Jun 2011 05:24:14 -0700
From: Sucheta Chakraborty <redacted>

When interface is down, driver prints false warning messages
during lro configuration through ethtool.

Signed-off-by: Sucheta Chakraborty <redacted>
Signed-off-by: Amit Kumar Salecha <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help