Thread (6 messages) 6 messages, 3 authors, 2011-06-18

Re: Section conflict compile failures in net

From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: 2011-06-01 01:45:16

Possibly related (same subject, not in this thread)

On Tue, 2011-05-31 at 15:45 -0700, David Miller wrote:
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: Thu, 26 May 2011 16:39:53 -0500

BTW, linux-netdev doesn't exist, it's just plain netdev.
Um, yes ... I thought it was netdev, then I checked MARC and it had
linux-netdev.  I'll remember for next time (well, at least for the next
six months).
quoted
Simply reverting 

commit e5cb966c0838e4da43a3b0751bdcac7fe719f7b4
Author: Micha<C5><82> Miros<C5><82>aw [off-list ref]
Date:   Mon Apr 18 13:31:20 2011 +0000

    net: fix section mismatches
    
Fixes the problem.

If I look at the first problem in hp100.c, the addition of
__devinitconst to the device tables is fine, but there's no
corresponding sectional tag on their use, so when compiled as a module,
things like hp100_eisa_driver is now in the main data section but refers
to something in the init data section ... I assume all the others are
the same type of problem.
Yeah I think the device ID table __devinitconst bits have to be
reverted.

I'll apply something like the following:

net: Revert adding __devinitconst to driver ID tables.

If the table is hooked up to foo_driver->id_table we can't
mark it __devinitconst otherwise we end up with section
mismatches.

Reported-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
That fixes some but not all; the pci tables still cause a section
conflict:

drivers/net/hp100.c:211: error: hp100_pci_tbl causes a section type conflict
make[2]: *** [drivers/net/hp100.o] Error 1


It's really, as has been said, a compiler problem: the compiler is
confused about the read only sections.  However, 4.2 is a pretty common
compiler (especially for non-x86), so if the compiler can't do the read
only section tracking, just not using the __devinitconst designation
globally seems to be the best thing, just change it to __devinitdata
instead.

James

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help