[PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings

Subsystems: networking [general], the rest

STALE5599d

5 messages, 5 authors, 2011-05-12 · open the first message on its own page

[PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings

From: <hidden>
Date: 2011-05-12 16:42:06

The issue was introduced in commit eed2a12f1ed9aabf.

Signed-off-by: Franco Fichtner <redacted>
---
 net/core/ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index b6f4058..b8c2b10 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -361,7 +361,7 @@ static const char
netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
 	/* NETIF_F_NTUPLE */          "rx-ntuple-filter",
 	/* NETIF_F_RXHASH */          "rx-hashing",
 	/* NETIF_F_RXCSUM */          "rx-checksum",
-	/* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy"
+	/* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy",
 	/* NETIF_F_LOOPBACK */        "loopback",
 };

--
1.7.3.2.493.g0b0cd

Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings

From: Michał Mirosław <hidden>
Date: 2011-05-12 16:45:33

2011/5/12  [off-list ref]:
quoted hunk
The issue was introduced in commit eed2a12f1ed9aabf.

Signed-off-by: Franco Fichtner <redacted>
---
 net/core/ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index b6f4058..b8c2b10 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -361,7 +361,7 @@ static const char
netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
       /* NETIF_F_NTUPLE */          "rx-ntuple-filter",
       /* NETIF_F_RXHASH */          "rx-hashing",
       /* NETIF_F_RXCSUM */          "rx-checksum",
-       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy"
+       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy",
       /* NETIF_F_LOOPBACK */        "loopback",
 };
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings

From: Ben Hutchings <hidden>
Date: 2011-05-12 17:58:36

On Thu, 2011-05-12 at 18:42 +0200, franco@lastsummer.de wrote:
The issue was introduced in commit eed2a12f1ed9aabf.

Signed-off-by: Franco Fichtner <redacted>
Acked-by: Ben Hutchings <redacted>
quoted hunk
---
 net/core/ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index b6f4058..b8c2b10 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -361,7 +361,7 @@ static const char
netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
 	/* NETIF_F_NTUPLE */          "rx-ntuple-filter",
 	/* NETIF_F_RXHASH */          "rx-hashing",
 	/* NETIF_F_RXCSUM */          "rx-checksum",
-	/* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy"
+	/* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy",
 	/* NETIF_F_LOOPBACK */        "loopback",
 };
-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings

From: Mahesh Bandewar <hidden>
Date: 2011-05-12 17:59:09

On Thu, May 12, 2011 at 9:45 AM, Michał Mirosław [off-list ref] wrote:
2011/5/12  [off-list ref]:
quoted
The issue was introduced in commit eed2a12f1ed9aabf.

Signed-off-by: Franco Fichtner <redacted>
---
 net/core/ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index b6f4058..b8c2b10 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -361,7 +361,7 @@ static const char
netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
       /* NETIF_F_NTUPLE */          "rx-ntuple-filter",
       /* NETIF_F_RXHASH */          "rx-hashing",
       /* NETIF_F_RXCSUM */          "rx-checksum",
-       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy"
+       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy",
       /* NETIF_F_LOOPBACK */        "loopback",
 };
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
 Acked-by: Mahesh Bandewar [off-list ref]

Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings

From: David Miller <davem@davemloft.net>
Date: 2011-05-12 21:50:49

From: Michał Mirosław <redacted>
Date: Thu, 12 May 2011 18:45:12 +0200
2011/5/12  [off-list ref]:
quoted
The issue was introduced in commit eed2a12f1ed9aabf.

Signed-off-by: Franco Fichtner <redacted>
---
 net/core/ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index b6f4058..b8c2b10 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -361,7 +361,7 @@ static const char
netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
       /* NETIF_F_NTUPLE */          "rx-ntuple-filter",
       /* NETIF_F_RXHASH */          "rx-hashing",
       /* NETIF_F_RXCSUM */          "rx-checksum",
-       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy"
+       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy",
       /* NETIF_F_LOOPBACK */        "loopback",
 };
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Applied, but this patch was significantly mangled by your email
client.  Please correct this problem before submitting future
patches, as I will just push them back to you if this happens
again.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help